Web Animations: Allow animations with delay to start on compositor

Source/core/animation/ActiveAnimations.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 57 matching lines @@
     if (!renderer.node() || !renderer.node()->isElementNode())
         return false;
 
     const Element* element = toElement(renderer.node());
     if (const ActiveAnimations* activeAnimations = element->activeAnimations())
         return activeAnimations->hasActiveAnimationsOnCompositor(property);
 
     return false;
 }
 
 bool ActiveAnimations::hasActiveAnimations(CSSPropertyID property) const

[shans, 2014/03/17 04:03:47]

This name is no longer correct.

[dstockwell, 2014/03/17 04:16:34]

FIXME, I think we'll want to consider renaming most of this class to be about
'current' rather than 'active' animations.

 {
-    return m_defaultStack.affects(property);
+    for (PlayerSet::const_iterator it = m_players.begin(); it != players().end(); ++it) {
+        const Player& player = *it->key;
+        ASSERT(player.source());
+        // FIXME: Needs to consider AnimationGroup once added.
+        ASSERT(player.source()->isAnimation());
+        const Animation& animation = *toAnimation(player.source());
+        if (animation.isCurrent() && animation.affects(property))
+            return true;
+    }
+    return false;

[shans, 2014/03/17 04:03:47]

Can m_defaultStack reflect animations that are pending?

[dstockwell, 2014/03/17 04:16:34]

Possibly, or perhaps we should create a separate collection of current (but not
active) animations for a given element. We'll need to do something here when I
add groups.

 }
 
 bool ActiveAnimations::hasActiveAnimationsOnCompositor(CSSPropertyID property) const
 {
     return m_defaultStack.hasActiveAnimationsOnCompositor(property);
 }
 
 void ActiveAnimations::cancelAnimationOnCompositor()
 {
     for (PlayerSet::iterator it = m_players.begin(); it != players().end(); ++it)
         it->key->cancelAnimationOnCompositor();
 }
 
 } // namespace WebCore