scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json - Issue 1898823002: Reland of Switch Android gtests to use generated wrapper scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json

Issue 1898823002: Reland of Switch Android gtests to use generated wrapper scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Add back in a TODO comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/amp_split_recipe_trigger_failure.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json

diff --git a/scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json b/scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json

index 52180e2a33aab92242d94bab01323cddef17180f..993194ea3ccc7438c49f8d3e75b0bb6a38c92c78 100644

--- a/scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json

+++ b/scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json

@@ -329,7 +329,8 @@

"--goma-dir",

"[SLAVE_BUILD]/src/build/goma/client",

"--",

- "base_unittests_apk"

+ "base_unittests_apk",

+ "bin/run_base_unittests"

"cwd": "[SLAVE_BUILD]",

"env": {

@@ -405,22 +406,17 @@

"cmd": [

"python",

"-u",

- "[SLAVE_BUILD]/src/build/android/test_runner.py",

- "gtest",

- "-s",

- "base_unittests",

+ "[SLAVE_BUILD]/src/out/Release/bin/run_base_unittests",

"--isolate-file-path=src/base/base_unittests.isolate",

"--blacklist-file",

"[SLAVE_BUILD]/src/out/bad_devices.json",

"--verbose",

- "--release",

"--flakiness-dashboard-server=test-results.appspot.com",

"--json-results-file",

"/path/to/tmp/json"

"cwd": "[SLAVE_BUILD]",

"env": {

- "CHROMIUM_OUTPUT_DIR": "[SLAVE_BUILD]/src/out/Release",

"PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"

"name": "base_unittests"