third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 1898813002: Allow throttling in painting microbenchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 1898813002: Allow throttling in painting microbenchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('j') | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 9b875d2cff7c21b68db1c33c6a2a850cf86571eb..1d06947fc69d72853ae6acd9808d0b59c6ff477e 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -2316,6 +2316,9 @@ void CompositedLayerMapping::paintContents(const GraphicsLayer* graphicsLayer, G

{

// https://code.google.com/p/chromium/issues/detail?id=343772

DisableCompositingQueryAsserts disabler;

+ // Allow throttling to make sure no painting paths (e.g.,

+ // ContentLayerDelegate::paintContents) try to paint throttled content.

+ DocumentLifecycle::AllowThrottlingScope allowThrottling(m_owningLayer.layoutObject()->document().lifecycle());

#if ENABLE(ASSERT)

// FIXME: once the state machine is ready, this can be removed and we can refer to that instead.

if (Page* page = layoutObject()->frame()->page())

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('j') | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('J')