Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1898803003: Don't set capabilities_.gpu.image in SurfacesContextProvider. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, piman, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set capabilities_.gpu.image in SurfacesContextProvider. The capabilities_ are overwriten in BindToCurrentThread anyways. R=fsamuel@chromium.org BUG=584497 Committed: https://crrev.com/43b1d014c428e08241af40b4f84e88752d20243c Cr-Commit-Position: refs/heads/master@{#388289}

Patch Set 1 : surface-image #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M components/mus/surfaces/surfaces_context_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
danakj
4 years, 8 months ago (2016-04-19 02:04:36 UTC) #1
danakj
Is this covered by tests? Should I run something?
4 years, 8 months ago (2016-04-19 02:04:53 UTC) #2
Fady Samuel
Lgtm. We don't have good test coverage unfortunately as this was experimental code. Hopefully this ...
4 years, 8 months ago (2016-04-19 03:09:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898803003/1
4 years, 8 months ago (2016-04-19 19:55:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 20:00:14 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43b1d014c428e08241af40b4f84e88752d20243c
Cr-Commit-Position: refs/heads/master@{#388289}

Powered by Google App Engine
This is Rietveld 408576698