Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1898793004: Cleanup android build files and tools (Closed)

Created:
4 years, 8 months ago by djsollen
Modified:
4 years, 8 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -34 lines) Patch
M gyp/visualbench.gyp View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
M platform_tools/android/launcher/skia_launcher.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
djsollen
4 years, 8 months ago (2016-04-18 19:44:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898793004/1
4 years, 8 months ago (2016-04-18 19:44:41 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-18 19:44:42 UTC) #6
scroggo
lgtm
4 years, 8 months ago (2016-04-18 19:53:57 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 19:57:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9df5d072094544fe47f9defbd3580a4dcfbe4167

Powered by Google App Engine
This is Rietveld 408576698