net/tools/quic/test_tools/packet_dropping_test_writer.h - Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/test_tools/packet_dropping_test_writer.h

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: fixing rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc ('k') | net/tools/quic/test_tools/packet_dropping_test_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/tools/quic/test_tools/packet_dropping_test_writer.h

diff --git a/net/tools/quic/test_tools/packet_dropping_test_writer.h b/net/tools/quic/test_tools/packet_dropping_test_writer.h

index 999825e6c82bbde8b6b9b4866fc76de2bfa1547a..2d96e2aeadce1b4138d18e1adaefacede4cc427d 100644

--- a/net/tools/quic/test_tools/packet_dropping_test_writer.h

+++ b/net/tools/quic/test_tools/packet_dropping_test_writer.h

@@ -44,6 +44,7 @@ class PacketDroppingTestWriter : public QuicPacketWriterWrapper {

// |on_can_write| will be triggered when fake-unblocking; ownership will be

// assumed.

void Initialize(QuicConnectionHelperInterface* helper,

+ QuicAlarmFactory* alarm_factory,

Delegate* on_can_write);