net/tools/quic/quic_epoll_connection_helper.h - Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_epoll_connection_helper.h

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: fixing rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_epoll_connection_helper.h

diff --git a/net/tools/quic/quic_epoll_connection_helper.h b/net/tools/quic/quic_epoll_connection_helper.h

index fd18fb3432d0fc6f3035ed125bdd085fdb8a1416..f5570631847315b00a08ed7ae1c72853f1f76774 100644

--- a/net/tools/quic/quic_epoll_connection_helper.h

+++ b/net/tools/quic/quic_epoll_connection_helper.h

@@ -43,11 +43,6 @@ class QuicEpollConnectionHelper : public QuicConnectionHelperInterface {

// QuicEpollConnectionHelperInterface

const QuicClock* GetClock() const override;

QuicRandom* GetRandomGenerator() override;

- QuicAlarm* CreateAlarm(QuicAlarm::Delegate* delegate) override;

- QuicArenaScopedPtr<QuicAlarm> CreateAlarm(

- QuicArenaScopedPtr<QuicAlarm::Delegate> delegate,

- QuicConnectionArena* arena) override;

QuicBufferAllocator* GetBufferAllocator() override;

EpollServer* epoll_server() { return epoll_server_; }

@@ -56,7 +51,6 @@ class QuicEpollConnectionHelper : public QuicConnectionHelperInterface {

friend class QuicConnectionPeer;

EpollServer* epoll_server_; // Not owned.

const QuicEpollClock clock_;

QuicRandom* random_generator_;

// Set up both allocators. They take up minimal memory before use.

« no previous file with comments | « net/tools/quic/quic_epoll_alarm_factory.cc ('k') | net/tools/quic/quic_epoll_connection_helper.cc » ('j') | no next file with comments »