net/quic/test_tools/mock_quic_dispatcher.h - Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/mock_quic_dispatcher.h

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: fixing rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/test_tools/mock_quic_dispatcher.h

diff --git a/net/quic/test_tools/mock_quic_dispatcher.h b/net/quic/test_tools/mock_quic_dispatcher.h

index 05c9c9baa550187df32e80aa69f2d3a2c9bd2b6e..1c73e7b8967ca1d7d990a6e413361ed909a45b72 100644

--- a/net/quic/test_tools/mock_quic_dispatcher.h

+++ b/net/quic/test_tools/mock_quic_dispatcher.h

@@ -20,8 +20,8 @@ class MockQuicDispatcher : public QuicDispatcher {

public:

MockQuicDispatcher(const QuicConfig& config,

const QuicCryptoServerConfig* crypto_config,

- QuicConnectionHelperInterface* helper);

+ std::unique_ptr<QuicConnectionHelperInterface> helper,

+ std::unique_ptr<QuicAlarmFactory> alarm_factory);

~MockQuicDispatcher() override;

MOCK_METHOD3(ProcessPacket,

« no previous file with comments | « net/quic/test_tools/crypto_test_utils.cc ('k') | net/quic/test_tools/mock_quic_dispatcher.cc » ('j') | no next file with comments »