net/net.gypi - Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/net.gypi

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: fixing rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/net.gypi

diff --git a/net/net.gypi b/net/net.gypi

index 9cbcd90587c4a6fcc85d6950aaa7430fe567c260..e2ef564e302e7da120c701b5a886f811482609c3 100644

--- a/net/net.gypi

+++ b/net/net.gypi

@@ -330,6 +330,7 @@

'quic/quic_address_mismatch.h',

'quic/quic_alarm.cc',

'quic/quic_alarm.h',

+ 'quic/quic_alarm_factory.h',

'quic/quic_arena_scoped_ptr.h',

'quic/quic_bandwidth.cc',

'quic/quic_bandwidth.h',

@@ -347,6 +348,8 @@

'quic/quic_connection_stats.h',

'quic/quic_crypto_stream.cc',

'quic/quic_crypto_stream.h',

+ 'quic/quic_chromium_alarm_factory.cc',

+ 'quic/quic_chromium_alarm_factory.h',

'quic/quic_chromium_connection_helper.cc',

'quic/quic_chromium_connection_helper.h',

'quic/quic_chromium_packet_reader.cc',

@@ -1616,6 +1619,7 @@

'quic/quic_alarm_test.cc',

'quic/quic_arena_scoped_ptr_test.cc',

'quic/quic_bandwidth_test.cc',

+ 'quic/quic_chromium_alarm_factory_test.cc',

'quic/quic_chromium_client_session_test.cc',

'quic/quic_chromium_client_stream_test.cc',

'quic/quic_chromium_connection_helper_test.cc',

@@ -1849,6 +1853,7 @@

'tools/quic/quic_client_test.cc',

'tools/quic/quic_dispatcher_test.cc',

'tools/quic/quic_epoll_clock_test.cc',

+ 'tools/quic/quic_epoll_alarm_factory_test.cc',

'tools/quic/quic_epoll_connection_helper_test.cc',

'tools/quic/quic_in_memory_cache_test.cc',

'tools/quic/quic_server_session_base_test.cc',

« no previous file with comments | « net/net.gyp ('k') | net/quic/bidirectional_stream_quic_impl_unittest.cc » ('j') | no next file with comments »