Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1898733002: [turbofan] Remove mutual recursion in typed-lowering of JSToNumber input. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove mutual recursion in typed-lowering of JSToNumber input. The recursion does seem to help anything. Committed: https://crrev.com/3a69613481a0ad7bdd8c56e0e10c613bd034b4d3 Cr-Commit-Position: refs/heads/master@{#35608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Jarin
Could you take a look, please?
4 years, 8 months ago (2016-04-18 11:39:36 UTC) #1
Jarin
Another attempt, now with a reviewer assigned. Could you take a look, please?
4 years, 8 months ago (2016-04-18 14:04:30 UTC) #4
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-18 17:48:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898733002/1
4 years, 8 months ago (2016-04-19 09:03:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 09:06:01 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 09:07:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a69613481a0ad7bdd8c56e0e10c613bd034b4d3
Cr-Commit-Position: refs/heads/master@{#35608}

Powered by Google App Engine
This is Rietveld 408576698