Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1898653003: [turbofan] Optimize typeof in abstract/strict equality comparison. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize typeof in abstract/strict equality comparison. Add support to optimize certain comparisons of typeof with known strings to utilize the existing ObjectIs<Type> predicates. Also add a new ObjectIsCallable, which is used to optimize the common typeof x === "function" pattern. R=jarin@chromium.org Committed: https://crrev.com/e96c143171a31d2bb0982a6896c93e12441cee45 Cr-Commit-Position: refs/heads/master@{#35562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -1 line) Patch
M src/compiler/change-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +48 lines, -0 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-674753.js View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-18 05:54:58 UTC) #1
Benedikt Meurer
Hey Jaro, Simple optimization. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-18 05:55:30 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-18 06:54:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898653003/1
4 years, 8 months ago (2016-04-18 07:01:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 07:03:16 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 07:03:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e96c143171a31d2bb0982a6896c93e12441cee45
Cr-Commit-Position: refs/heads/master@{#35562}

Powered by Google App Engine
This is Rietveld 408576698