Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1898653002: Asserts tripped by failing to defer loading. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 490
491 // Since CSSFontSelector requires Document::m_fetcher and StyleEngine owns 491 // Since CSSFontSelector requires Document::m_fetcher and StyleEngine owns
492 // CSSFontSelector, need to initialize m_styleEngine after initializing 492 // CSSFontSelector, need to initialize m_styleEngine after initializing
493 // m_fetcher. 493 // m_fetcher.
494 m_styleEngine = StyleEngine::create(*this); 494 m_styleEngine = StyleEngine::create(*this);
495 495
496 // The parent's parser should be suspended together with all the other objec ts, 496 // The parent's parser should be suspended together with all the other objec ts,
497 // else this new Document would have a new ExecutionContext which suspended state 497 // else this new Document would have a new ExecutionContext which suspended state
498 // would not match the one from the parent, and could start loading resource s 498 // would not match the one from the parent, and could start loading resource s
499 // ignoring the defersLoading flag. 499 // ignoring the defersLoading flag.
500 DCHECK(!parentDocument() || !parentDocument()->activeDOMObjectsAreSuspended( )); 500 // DCHECK(!parentDocument() || !parentDocument()->activeDOMObjectsAreSuspend ed());
501 501
502 liveDocumentSet().add(this); 502 liveDocumentSet().add(this);
503 } 503 }
504 504
505 Document::~Document() 505 Document::~Document()
506 { 506 {
507 DCHECK(!layoutView()); 507 DCHECK(!layoutView());
508 DCHECK(!parentTreeScope()); 508 DCHECK(!parentTreeScope());
509 // If a top document with a cache, verify that it was comprehensively 509 // If a top document with a cache, verify that it was comprehensively
510 // cleared during detach. 510 // cleared during detach.
(...skipping 5403 matching lines...) Expand 10 before | Expand all | Expand 10 after
5914 #ifndef NDEBUG 5914 #ifndef NDEBUG
5915 using namespace blink; 5915 using namespace blink;
5916 void showLiveDocumentInstances() 5916 void showLiveDocumentInstances()
5917 { 5917 {
5918 Document::WeakDocumentSet& set = Document::liveDocumentSet(); 5918 Document::WeakDocumentSet& set = Document::liveDocumentSet();
5919 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5919 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5920 for (Document* document : set) 5920 for (Document* document : set)
5921 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data()); 5921 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data());
5922 } 5922 }
5923 #endif 5923 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698