Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3130)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h

Issue 1898643002: Refactor device::BluetoothGattXXX classes to split into remote/local. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h
deleted file mode 100644
index 4f9d1227bfd407e05ce77d71b0363143a2fd97b8..0000000000000000000000000000000000000000
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h
+++ /dev/null
@@ -1,131 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_
-#define DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_
-
-#include <stddef.h>
-#include <stdint.h>
-#include <queue>
-#include <string>
-#include <utility>
-#include <vector>
-
-#include "base/callback_forward.h"
-#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
-#include "dbus/object_path.h"
-#include "device/bluetooth/bluetooth_gatt_characteristic.h"
-#include "device/bluetooth/bluetooth_gatt_characteristic_bluez.h"
-#include "device/bluetooth/bluetooth_uuid.h"
-#include "device/bluetooth/dbus/bluetooth_gatt_descriptor_client.h"
-
-namespace device {
-
-class BluetoothGattDescriptor;
-class BluetoothGattService;
-
-} // namespace device
-
-namespace bluez {
-
-class BluetoothGattDescriptorBlueZ;
-class BluetoothRemoteGattServiceBlueZ;
-
-// The BluetoothRemoteGattCharacteristicBlueZ class implements
-// BluetoothGattCharacteristic for remote GATT characteristics for platforms
-// that use BlueZ.
-class BluetoothRemoteGattCharacteristicBlueZ
- : public BluetoothGattCharacteristicBlueZ,
- public BluetoothGattDescriptorClient::Observer {
- public:
- // device::BluetoothGattCharacteristic overrides.
- device::BluetoothUUID GetUUID() const override;
- bool IsLocal() const override;
- const std::vector<uint8_t>& GetValue() const override;
- Properties GetProperties() const override;
- bool IsNotifying() const override;
- bool AddDescriptor(device::BluetoothGattDescriptor* descriptor) override;
- bool UpdateValue(const std::vector<uint8_t>& value) override;
- void StartNotifySession(const NotifySessionCallback& callback,
- const ErrorCallback& error_callback) override;
- void ReadRemoteCharacteristic(const ValueCallback& callback,
- const ErrorCallback& error_callback) override;
- void WriteRemoteCharacteristic(const std::vector<uint8_t>& new_value,
- const base::Closure& callback,
- const ErrorCallback& error_callback) override;
-
- // Removes one value update session and invokes |callback| on completion. This
- // decrements the session reference count by 1 and if the number reaches 0,
- // makes a call to the subsystem to stop notifications from this
- // characteristic.
- void RemoveNotifySession(const base::Closure& callback);
-
- private:
- friend class BluetoothRemoteGattServiceBlueZ;
-
- using PendingStartNotifyCall =
- std::pair<NotifySessionCallback, ErrorCallback>;
-
- BluetoothRemoteGattCharacteristicBlueZ(
- BluetoothRemoteGattServiceBlueZ* service,
- const dbus::ObjectPath& object_path);
- ~BluetoothRemoteGattCharacteristicBlueZ() override;
-
- // bluez::BluetoothGattDescriptorClient::Observer overrides.
- void GattDescriptorAdded(const dbus::ObjectPath& object_path) override;
- void GattDescriptorRemoved(const dbus::ObjectPath& object_path) override;
- void GattDescriptorPropertyChanged(const dbus::ObjectPath& object_path,
- const std::string& property_name) override;
-
- // Called by dbus:: on successful completion of a request to start
- // notifications.
- void OnStartNotifySuccess(const NotifySessionCallback& callback);
-
- // Called by dbus:: on unsuccessful completion of a request to start
- // notifications.
- void OnStartNotifyError(const ErrorCallback& error_callback,
- const std::string& error_name,
- const std::string& error_message);
-
- // Called by dbus:: on successful completion of a request to stop
- // notifications.
- void OnStopNotifySuccess(const base::Closure& callback);
-
- // Called by dbus:: on unsuccessful completion of a request to stop
- // notifications.
- void OnStopNotifyError(const base::Closure& callback,
- const std::string& error_name,
- const std::string& error_message);
-
- // Calls StartNotifySession for each queued request.
- void ProcessStartNotifyQueue();
-
- // Called by dbus:: on unsuccessful completion of a request to read or write
- // the characteristic value.
- void OnError(const ErrorCallback& error_callback,
- const std::string& error_name,
- const std::string& error_message);
-
- // The total number of currently active value update sessions.
- size_t num_notify_sessions_;
-
- // Calls to StartNotifySession that are pending. This can happen during the
- // first remote call to start notifications.
- std::queue<PendingStartNotifyCall> pending_start_notify_calls_;
-
- // True, if a Start or Stop notify call to bluetoothd is currently pending.
- bool notify_call_pending_;
-
- // Note: This should remain the last member so it'll be destroyed and
- // invalidate its weak pointers before any other members are destroyed.
- base::WeakPtrFactory<BluetoothRemoteGattCharacteristicBlueZ>
- weak_ptr_factory_;
-
- DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristicBlueZ);
-};
-
-} // namespace bluez
-
-#endif // DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_

Powered by Google App Engine
This is Rietveld 408576698