device/bluetooth/bluetooth_device_win.cc - Issue 1898643002: Refactor device::BluetoothGattXXX classes to split into remote/local.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_device_win.cc

Issue 1898643002: Refactor device::BluetoothGattXXX classes to split into remote/local. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.h ('K') | « device/bluetooth/bluetooth_device_win.h ('k') | device/bluetooth/bluetooth_gatt_bluez_unittest.cc » ('j') | device/bluetooth/bluetooth_gatt_characteristic.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_device_win.cc

diff --git a/device/bluetooth/bluetooth_device_win.cc b/device/bluetooth/bluetooth_device_win.cc

index 8c1033609c6650dae1d48a605e68c953b754af35..525ab0a1d9da8f5e2aa24adcabc9d13e46845e1d 100644

--- a/device/bluetooth/bluetooth_device_win.cc

+++ b/device/bluetooth/bluetooth_device_win.cc

@@ -342,7 +342,7 @@ bool BluetoothDeviceWin::IsGattServiceDiscovered(BluetoothUUID& uuid,

bool BluetoothDeviceWin::DoesGattServiceExist(

const ScopedVector<BluetoothTaskManagerWin::ServiceRecordState>&

service_state,

- BluetoothGattService* service) {

+ BluetoothRemoteGattService* service) {

uint16_t attribute_handle =

static_cast<BluetoothRemoteGattServiceWin*>(service)

->GetAttributeHandle();

@@ -392,7 +392,7 @@ void BluetoothDeviceWin::UpdateGattServices(

nullptr, ui_task_runner_);

gatt_services_.add(

primary_service->GetIdentifier(),

- std::unique_ptr<BluetoothGattService>(primary_service));

+ std::unique_ptr<BluetoothRemoteGattService>(primary_service));

adapter_->NotifyGattServiceAdded(primary_service);

}