Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1898633006: headless: Fix handling of replies without any parameters (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
Reviewers:
altimin
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Fix handling of replies without any parameters Fix handling of replies to DevTools commands which don't include any parameters. Previously we used th presence of the reply dictionary to decide between a callback with or without parameters, but this dictionary can be present in the reply also when there are no actual parameters in it. BUG=595353 Committed: https://crrev.com/7161641ae3eb7d4dd77c5c1884b34dd091ec8d39 Cr-Commit-Position: refs/heads/master@{#388543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M headless/lib/browser/headless_devtools_client_impl.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M headless/lib/headless_devtools_client_browsertest.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 8 months ago (2016-04-20 14:53:49 UTC) #3
altimin
lgtm
4 years, 8 months ago (2016-04-20 16:06:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898633006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898633006/1
4 years, 8 months ago (2016-04-20 17:44:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 19:05:13 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7161641ae3eb7d4dd77c5c1884b34dd091ec8d39
Cr-Commit-Position: refs/heads/master@{#388543}

Powered by Google App Engine
This is Rietveld 408576698