Views: Add new SetFocusBehavior method.

ui/views/view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_VIEW_H_
 #define UI_VIEWS_VIEW_H_
 
 #include <stddef.h>
 
 #include <algorithm>
@@ skipping 98 matching lines @@
 //
 /////////////////////////////////////////////////////////////////////////////
 class VIEWS_EXPORT View : public ui::LayerDelegate,
                           public ui::LayerOwner,
                           public ui::AcceleratorTarget,
                           public ui::EventTarget,
                           public ui::EventHandler {
  public:
   typedef std::vector<View*> Views;
 
+  enum class FocusBehavior {
+    // Use when the view is to be focusable both in default and full keyboard

[tapted, 2016/04/20 04:16:28]

nit: view -> View. Also `full keyboard access` is a bit of a Mac thing. Perhaps 
    // The View is focusable in regular and accessibility modes.

[karandeepb, 2016/04/21 03:16:33]

Done. Although the existing comment for IsAccessibilityFocusable uses full
keyboard access as well.

+    // access mode.
+    ALWAYS,
+
+    // Use when view is never focusable. Default.

[tapted, 2016/04/20 04:16:28]

nit: view -> View. Also the default should come first in the enum.

[sky, 2016/04/20 19:26:02]

And 'view' -> 'the view'

[karandeepb, 2016/04/21 03:16:33]

Done.

[karandeepb, 2016/04/21 03:16:33]

Done.

+    NEVER,
+
+    // Use when the view is to be made focusable only during full keyboard mode.

[tapted, 2016/04/20 04:16:28]

    // The View is focusable only in accessibility modes.

[karandeepb, 2016/04/21 03:16:33]

Done.

+    ACCESSIBLE_ONLY,
+  };
+
   struct ViewHierarchyChangedDetails {
     ViewHierarchyChangedDetails()
         : is_add(false),
           parent(NULL),
           child(NULL),
           move_view(NULL) {}
 
     ViewHierarchyChangedDetails(bool is_add,
                                 View* parent,
                                 View* child,
@@ skipping 631 matching lines @@
   // Returns the view that should be selected next when pressing Shift-Tab.
   View* GetPreviousFocusableView();
 
   // Sets the component that should be selected next when pressing Tab, and
   // makes the current view the precedent view of the specified one.
   // Note that by default views are linked in the order they have been added to
   // their container. Use this method if you want to modify the order.
   // IMPORTANT NOTE: loops in the focus hierarchy are not supported.
   void SetNextFocusableView(View* view);
 
-  // Sets whether this view is capable of taking focus. It will clear focus if
-  // the focused view is set to be non-focusable.
-  // Note that this is false by default so that a view used as a container does
-  // not get the focus.
-  void SetFocusable(bool focusable);
+  // Sets |focusable_| and |accessibility_focusable_| corresponding to the given
+  // |focus_behavior|.

[tapted, 2016/04/20 04:16:28]

If we get rid of Set[Accessibility]Focusable (I think we should - see later
comments), then we should expand on this comment.

[karandeepb, 2016/04/21 03:16:33]

Done.

+  void SetFocusBehavior(FocusBehavior focus_behavior);
 
   // Returns true if this view is |focusable_|, |enabled_| and drawn.
   bool IsFocusable() const;
 
   // Return whether this view is focusable when the user requires full keyboard
   // access, even though it may not be normally focusable.
   bool IsAccessibilityFocusable() const;
 
-  // Set whether this view can be made focusable if the user requires
-  // full keyboard access, even though it's not normally focusable. It will
-  // clear focus if the focused view is set to be non-focusable.
-  // Note that this is false by default.
-  void SetAccessibilityFocusable(bool accessibility_focusable);
-
   // Convenience method to retrieve the FocusManager associated with the
   // Widget that contains this view.  This can return NULL if this view is not
   // part of a view hierarchy with a Widget.
   virtual FocusManager* GetFocusManager();
   virtual const FocusManager* GetFocusManager() const;
 
   // Request keyboard focus. The receiving view will become the focused view.
   virtual void RequestFocus();
 
   // Invoked when a view is about to be requested for focus due to the focus
@@ skipping 578 matching lines @@
   // FocusManager yet, if possible.
   void RegisterPendingAccelerators();
 
   // Unregisters all the keyboard accelerators associated with this view.
   // |leave_data_intact| if true does not remove data from accelerators_ array,
   // so it could be re-registered with other focus manager
   void UnregisterAccelerators(bool leave_data_intact);
 
   // Focus ---------------------------------------------------------------------
 
+  // Helper method for SetFocusBehavior(..).
+  // Sets whether this view is capable of taking focus. It will clear focus if
+  // the focused view is set to be non-focusable.
+  // Note that this is false by default so that a view used as a container does
+  // not get the focus.
+  void SetFocusable(bool focusable);

[sky, 2016/04/20 19:26:02]

Is this temporary? We should only have SetFocusBehavior.

[karandeepb, 2016/04/21 03:16:33]

Done.

+
+  // Helper method for SetFocusBehavior(..).
+  // Set whether this view can be made focusable if the user requires

[tapted, 2016/04/20 04:16:28]

nit: rewrap

[karandeepb, 2016/04/21 03:16:33]

Removed this.

+  // full keyboard access, even though it's not normally focusable. It will
+  // clear focus if the focused view is set to be non-focusable.
+  // Note that this is false by default.
+  void SetAccessibilityFocusable(bool accessibility_focusable);
+
   // Initialize the previous/next focusable views of the specified view relative
   // to the view at the specified index.
   void InitFocusSiblings(View* view, int index);
 
   // Helper function to advance focus, in case the currently focused view has
   // become unfocusable.
   void AdvanceFocusIfNecessary();
 
   // System events -------------------------------------------------------------
 
@@ skipping 172 matching lines @@
   // Belongs to this view, but it's reference-counted on some platforms
   // so we can't use a scoped_ptr. It's dereferenced in the destructor.
   NativeViewAccessibility* native_view_accessibility_;
 
   DISALLOW_COPY_AND_ASSIGN(View);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_VIEW_H_