Views: Add new SetFocusBehavior method.

ui/views/controls/label_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 358 matching lines @@
   Label label(base::ASCIIToUTF16("Example"));
   gfx::Size preferred_size = label.GetPreferredSize();
 
   label.SetMultiLine(true);
   label.SetAllowCharacterBreak(true);
   EXPECT_EQ(preferred_size, label.GetPreferredSize());
 }
 
 TEST_F(LabelTest, MultiLineSizing) {
   Label label;
-  label.SetFocusable(false);
+  label.SetFocusBehavior(View::FocusBehavior::NEVER);

[tapted, 2016/04/20 04:16:28]

the NEVERs here and on line 464 can be deleted - it doesn't make sense just for
these two tests to call it without a comment (although maybe there's something
in `git blame` or the review about it)

[karandeepb, 2016/04/21 03:16:33]

Done. Didn't find anything interesting in git blame. 

   label.SetText(
       ASCIIToUTF16("A random string\nwith multiple lines\nand returns!"));
   label.SetMultiLine(true);
 
   // GetPreferredSize
   gfx::Size required_size = label.GetPreferredSize();
   EXPECT_GT(required_size.height(), kMinTextDimension);
   EXPECT_GT(required_size.width(), kMinTextDimension);
 
   // SizeToFit with unlimited width.
@@ skipping 64 matching lines @@
   EXPECT_EQ(required_size_with_border.width(),
             required_size.width() + border.width());
 }
 
 // Verifies if the combination of text eliding and multiline doesn't cause
 // any side effects of size / layout calculation.
 TEST_F(LabelTest, MultiLineSizingWithElide) {
   const base::string16 text =
       ASCIIToUTF16("A random string\nwith multiple lines\nand returns!");
   Label label;
-  label.SetFocusable(false);
+  label.SetFocusBehavior(View::FocusBehavior::NEVER);
   label.SetText(text);
   label.SetMultiLine(true);
 
   gfx::Size required_size = label.GetPreferredSize();
   EXPECT_GT(required_size.height(), kMinTextDimension);
   EXPECT_GT(required_size.width(), kMinTextDimension);
   label.SetBoundsRect(gfx::Rect(required_size));
 
   label.SetElideBehavior(gfx::ELIDE_TAIL);
   EXPECT_EQ(required_size.ToString(), label.GetPreferredSize().ToString());
@@ skipping 130 matching lines @@
 
   // There's only one 'line', RenderText itself supports multiple lines.
   EXPECT_EQ(1u, label.lines_.size());
 }
 #endif
 
 TEST_F(LabelFocusTest, FocusBounds) {
   label()->SetText(ASCIIToUTF16("Example"));
   gfx::Size normal_size = label()->GetPreferredSize();
 
-  label()->SetFocusable(true);
+  label()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   label()->RequestFocus();
   gfx::Size focusable_size = label()->GetPreferredSize();
   // Focusable label requires larger size to paint the focus rectangle.
   EXPECT_GT(focusable_size.width(), normal_size.width());
   EXPECT_GT(focusable_size.height(), normal_size.height());
 
   label()->SizeToPreferredSize();
   gfx::Rect focus_bounds = label()->GetFocusBounds();
   EXPECT_EQ(label()->GetLocalBounds().ToString(), focus_bounds.ToString());
 
@@ skipping 16 matching lines @@
 
   label()->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   label()->SetElideBehavior(gfx::FADE_TAIL);
   label()->SetBounds(0, 0, focusable_size.width() / 2, focusable_size.height());
   focus_bounds = label()->GetFocusBounds();
   EXPECT_EQ(0, focus_bounds.x());
   EXPECT_EQ(focusable_size.width() / 2, focus_bounds.width());
 }
 
 TEST_F(LabelFocusTest, EmptyLabel) {
-  label()->SetFocusable(true);
+  label()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   label()->RequestFocus();
   label()->SizeToPreferredSize();
 
   gfx::Rect focus_bounds = label()->GetFocusBounds();
   EXPECT_FALSE(focus_bounds.IsEmpty());
   EXPECT_LT(label()->font_list().GetHeight(), focus_bounds.height());
 }
 
 }  // namespace views