Ryan Sleevi
2016/04/27 20:51:08
I would prefer not to introduce a per-file OWNERS
I would prefer not to introduce a per-file OWNERS here. While I realize Ben is
unquestionably the person most likely to know how this all relates, ideally, we
would have more members of the team who know how to review this code.
Ben, do you feel strongly about this? Did I miss a concern?
tbansal1
2016/04/27 20:59:49
Ben can add more but probably this is my bad. I as
On 2016/04/27 20:51:08, Ryan Sleevi wrote:
> I would prefer not to introduce a per-file OWNERS here. While I realize Ben is
> unquestionably the person most likely to know how this all relates, ideally,
we
> would have more members of the team who know how to review this code.
>
> Ben, do you feel strongly about this? Did I miss a concern?
Ben can add more but probably this is my bad. I assumed the OWNERS from the
parent folder would also apply to files in this folder too (because there is no
set noparent here). Is that not the case here?
tbansal1
2016/04/27 21:24:31
According to https://chromium.googlesource.com/chr
On 2016/04/27 20:59:49, tbansal1 wrote:
> On 2016/04/27 20:51:08, Ryan Sleevi wrote:
> > I would prefer not to introduce a per-file OWNERS here. While I realize Ben
is
> > unquestionably the person most likely to know how this all relates, ideally,
> we
> > would have more members of the team who know how to review this code.
> >
> > Ben, do you feel strongly about this? Did I miss a concern?
>
> Ben can add more but probably this is my bad. I assumed the OWNERS from the
> parent folder would also apply to files in this folder too (because there is
no
> set noparent here). Is that not the case here?
On 2016/04/27 21:24:31, tbansal1 wrote:
> Ryan, does that answer the concern?
Well, not quite, because I still am not terribly comfortable about per-file
OWNERS, so I wanted to confirm with Ben that he still wanted this. I'm not going
to object, but I'd like to make sure this is something intentional with Ben.
Definitely, the relationship with with the rest of socket APIs is important to
consider, so does it make sense for socket owners to do reviewing?
tbansal1
2016/04/28 20:06:45
Done. I have removed //net/socket/OWNERS.
On 2016/04/28 16:14:44, Ryan Sleevi wrote:
> On 2016/04/27 21:24:31, tbansal1 wrote:
> > Ryan, does that answer the concern?
>
> Well, not quite, because I still am not terribly comfortable about per-file
> OWNERS, so I wanted to confirm with Ben that he still wanted this. I'm not
going
> to object, but I'd like to make sure this is something intentional with Ben.
> Definitely, the relationship with with the rest of socket APIs is important to
> consider, so does it make sense for socket owners to do reviewing?
Issue 1898603002: Move Network Quality Estimator files to //net/nqe
(Closed)
Created 4 years, 8 months ago by tbansal1
Modified 4 years, 8 months ago
Reviewers: Ryan Sleevi, bengr, mmenke, mef, rohitrao (ping after 24h)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 5