Move Network Quality Estimator files to //net/nqe

Move Network Quality Estimator files to //net/nqe

This restructures the Network Quality Estimator files to
live in //net/nqe, rather than in //net/base. Additionally,
it moves the socket-related files into //net/socket.

BUG=601940
Committed: https://crrev.com/ca83c0041ebaebdfb1594824099156c1edd2789b
Cr-Commit-Position: refs/heads/master@{#390475}

[tbansal1, 2016-04-17 02:24:26]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-04-17 02:25:14]

Description was changed from

==========
Move NQE, SPW and SPWF

BUG=
==========

to

==========
Move NQE, SPW and SPWF

BUG=601940
==========

[tbansal1, 2016-04-17 02:30:48]

Description was changed from

==========
Move NQE, SPW and SPWF

BUG=601940
==========

to

==========
Move NQE, SPW and SPWF

Move //net/base/network_quality_estimator* and
//net/base/external_estimate_provider* files to
//net/nqe/

Move //net/base/socket_performance_watcher* files to
//net/socket/

Also, update the OWNERS at different locations accordingly.

BUG=601940
==========

[tbansal1, 2016-04-17 02:31:56]

Description was changed from

==========
Move NQE, SPW and SPWF

Move //net/base/network_quality_estimator* and
//net/base/external_estimate_provider* files to
//net/nqe/

Move //net/base/socket_performance_watcher* files to
//net/socket/

Also, update the OWNERS at different locations accordingly.

BUG=601940
==========

to

==========
Move NQE, EEP, SPW and SPWF

Move //net/base/network_quality_estimator* and
//net/base/external_estimate_provider* files to
//net/nqe/

Move //net/base/socket_performance_watcher* files to
//net/socket/

Also, update the OWNERS at different locations accordingly.

BUG=601940
==========

[tbansal1, 2016-04-17 02:47:04]

Patchset #1 (id:20001) has been deleted

[tbansal1, 2016-04-17 02:52:35]

Patchset #1 (id:40001) has been deleted

[tbansal1, 2016-04-18 16:09:53]

Patchset #1 (id:60001) has been deleted

[tbansal1, 2016-04-18 17:30:53]

tbansal@chromium.org changed reviewers:
+ rsleevi@chromium.org

[tbansal1, 2016-04-18 17:30:54]

Ryan: PTAL when you have time. Hopefully this will be quick to review. Thanks.

[tbansal1, 2016-04-18 17:33:43]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-04-18 17:33:44]

bengr: PTAL at everything
rsleevi: //net/*

[bengr, 2016-04-21 22:55:58]

lgtm

[Ryan Sleevi, 2016-04-27 20:45:38]

Description was changed from

==========
Move NQE, EEP, SPW and SPWF

Move //net/base/network_quality_estimator* and
//net/base/external_estimate_provider* files to
//net/nqe/

Move //net/base/socket_performance_watcher* files to
//net/socket/

Also, update the OWNERS at different locations accordingly.

BUG=601940
==========

to

==========
Move Network Quality Estimator files to //net/nqe

This restructures the Network Quality Estimator files to
live in //net/nqe, rather than in //net/base. Additionally,
it moves the socket-related files into //net/socket.

BUG=601940
==========

[Ryan Sleevi, 2016-04-27 20:51:08]

apologies for the delay on mostly mechanical changes.

LGTM, but please hold off until Ben has a chance to reply.

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS
File net/socket/OWNERS (right):

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS#newcode1
net/socket/OWNERS:1: per-file socket_performance_watcher*=bengr@chromium.org
I would prefer not to introduce a per-file OWNERS here. While I realize Ben is
unquestionably the person most likely to know how this all relates, ideally, we
would have more members of the team who know how to review this code.

Ben, do you feel strongly about this? Did I miss a concern?

[tbansal1, 2016-04-27 20:59:49]

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS
File net/socket/OWNERS (right):

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS#newcode1
net/socket/OWNERS:1: per-file socket_performance_watcher*=bengr@chromium.org
On 2016/04/27 20:51:08, Ryan Sleevi wrote:
> I would prefer not to introduce a per-file OWNERS here. While I realize Ben is
> unquestionably the person most likely to know how this all relates, ideally,
we
> would have more members of the team who know how to review this code.
> 
> Ben, do you feel strongly about this? Did I miss a concern?

Ben can add more but probably this is my bad. I assumed the OWNERS from the
parent folder would also apply to files in this folder too (because there is no
set noparent here). Is that not the case here?

[tbansal1, 2016-04-27 21:24:31]

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS
File net/socket/OWNERS (right):

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS#newcode1
net/socket/OWNERS:1: per-file socket_performance_watcher*=bengr@chromium.org
On 2016/04/27 20:59:49, tbansal1 wrote:
> On 2016/04/27 20:51:08, Ryan Sleevi wrote:
> > I would prefer not to introduce a per-file OWNERS here. While I realize Ben
is
> > unquestionably the person most likely to know how this all relates, ideally,
> we
> > would have more members of the team who know how to review this code.
> > 
> > Ben, do you feel strongly about this? Did I miss a concern?
> 
> Ben can add more but probably this is my bad. I assumed the OWNERS from the
> parent folder would also apply to files in this folder too (because there is
no
> set noparent here). Is that not the case here?

According to
https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/owners.py,
if there is no "set noparent" directive, OWNERS from parent folder
(//net/OWNERS) are also owners of all the files (including the files that have
per-file owners) in this folder. Ryan, does that answer the concern?

[tbansal1, 2016-04-28 14:02:27]

tbansal@chromium.org changed reviewers:
+ mef@chromium.org, mmenke@chromium.org, rohitrao@chromium.org

[tbansal1, 2016-04-28 14:02:27]

PTAL. Thanks.
mmenke: chrome/browser/profiles/profile_io_data.cc
mef: components/cronet*
rohitrao: ios/*

[rohitrao (ping after 24h), 2016-04-28 14:05:31]

ios lgtm

[mef, 2016-04-28 14:10:58]

cronet lgtm

[mmenke, 2016-04-28 14:48:51]

On 2016/04/28 14:10:58, mef wrote:
> cronet lgtm

profiles/ LGTM

[Ryan Sleevi, 2016-04-28 16:14:45]

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS
File net/socket/OWNERS (right):

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS#newcode1
net/socket/OWNERS:1: per-file socket_performance_watcher*=bengr@chromium.org
On 2016/04/27 21:24:31, tbansal1 wrote:
> Ryan, does that answer the concern?

Well, not quite, because I still am not terribly comfortable about per-file
OWNERS, so I wanted to confirm with Ben that he still wanted this. I'm not going
to object, but I'd like to make sure this is something intentional with Ben.
Definitely, the relationship with with the rest of socket APIs is important to
consider, so does it make sense for socket owners to do reviewing?

[tbansal1, 2016-04-28 17:22:56]

On 2016/04/28 16:14:45, Ryan Sleevi wrote:
> https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS
> File net/socket/OWNERS (right):
> 
>
https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS#newcode1
> net/socket/OWNERS:1: per-file
mailto:socket_performance_watcher*=bengr@chromium.org
> On 2016/04/27 21:24:31, tbansal1 wrote:
> > Ryan, does that answer the concern?
> 
> Well, not quite, because I still am not terribly comfortable about per-file
> OWNERS, so I wanted to confirm with Ben that he still wanted this. I'm not
going
> to object, but I'd like to make sure this is something intentional with Ben.
> Definitely, the relationship with with the rest of socket APIs is important to
> consider, so does it make sense for socket owners to do reviewing?

That makes sense. I have removed //net/socket/OWNERS. That ownership
was not very useful. Changes in SPW/SPWF are generally
accompanied with changes in //net/socket or //net/quic, so 
I would end up bothering net OWNERS anyways.

[tbansal1, 2016-04-28 20:06:45]

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS
File net/socket/OWNERS (right):

https://codereview.chromium.org/1898603002/diff/80001/net/socket/OWNERS#newcode1
net/socket/OWNERS:1: per-file socket_performance_watcher*=bengr@chromium.org
On 2016/04/28 16:14:44, Ryan Sleevi wrote:
> On 2016/04/27 21:24:31, tbansal1 wrote:
> > Ryan, does that answer the concern?
> 
> Well, not quite, because I still am not terribly comfortable about per-file
> OWNERS, so I wanted to confirm with Ben that he still wanted this. I'm not
going
> to object, but I'd like to make sure this is something intentional with Ben.
> Definitely, the relationship with with the rest of socket APIs is important to
> consider, so does it make sense for socket owners to do reviewing?

Done. I have removed //net/socket/OWNERS.

[tbansal1, 2016-04-28 20:50:12]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-04-28 20:50:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
mef@chromium.org, rsleevi@chromium.org, mmenke@chromium.org,
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/1898603002/#ps100001
(title: "Rebased, removed //net/socket/OWNERS")

[commit-bot: I haz the power, 2016-04-28 20:50:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898603002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898603002/100001

[commit-bot: I haz the power, 2016-04-28 20:56:46]

Description was changed from

==========
Move Network Quality Estimator files to //net/nqe

This restructures the Network Quality Estimator files to
live in //net/nqe, rather than in //net/base. Additionally,
it moves the socket-related files into //net/socket.

BUG=601940
==========

to

==========
Move Network Quality Estimator files to //net/nqe

This restructures the Network Quality Estimator files to
live in //net/nqe, rather than in //net/base. Additionally,
it moves the socket-related files into //net/socket.

BUG=601940
==========

[commit-bot: I haz the power, 2016-04-28 20:56:47]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:21:00]

Patchset 2 (id:??) landed as
https://crrev.com/ca83c0041ebaebdfb1594824099156c1edd2789b
Cr-Commit-Position: refs/heads/master@{#390475}

[commit-bot: I haz the power, 2016-04-30 17:57:26]

Description was changed from

==========
Move Network Quality Estimator files to //net/nqe

This restructures the Network Quality Estimator files to
live in //net/nqe, rather than in //net/base. Additionally,
it moves the socket-related files into //net/socket.

BUG=601940
==========

to

==========
Move Network Quality Estimator files to //net/nqe

This restructures the Network Quality Estimator files to
live in //net/nqe, rather than in //net/base. Additionally,
it moves the socket-related files into //net/socket.

BUG=601940

Committed: https://crrev.com/ca83c0041ebaebdfb1594824099156c1edd2789b
Cr-Commit-Position: refs/heads/master@{#390475}
==========