chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc - Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc

Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0039-picasa-import-sandbox-ini-parsing

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc ('K') | « chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc

diff --git a/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc b/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc

index 21205e0cddeaf3eb1eec271c48423fb0125e081c..64cdffc3ff3ea92673b3414ee300c233e91bacbc 100644

--- a/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc

+++ b/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc

@@ -121,7 +121,10 @@ void SafePicasaAlbumsIndexer::OnIndexPicasaAlbumsContentsFinished(

MediaFileSystemBackend::MediaTaskRunner()->PostTask(

FROM_HERE,

- base::Bind(callback_, true, albums_images));

+ base::Bind(callback_,

+ make_scoped_refptr(this),

+ true,

+ albums_images));

parser_state_ = FINISHED_PARSING_STATE;

}

@@ -130,7 +133,10 @@ void SafePicasaAlbumsIndexer::OnProcessCrashed(int exit_code) {

MediaFileSystemBackend::MediaTaskRunner()->PostTask(

FROM_HERE,

- base::Bind(callback_, false, AlbumImagesMap()));

+ base::Bind(callback_,

+ make_scoped_refptr(this),

+ false,

+ AlbumImagesMap()));

}

bool SafePicasaAlbumsIndexer::OnMessageReceived(