chrome/common/media_galleries/picasa_types.h - Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/media_galleries/picasa_types.h

Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0039-picasa-import-sandbox-ini-parsing

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc ('K') | « chrome/chrome_tests.gypi ('k') | chrome/common/media_galleries/picasa_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/media_galleries/picasa_types.h

diff --git a/chrome/common/media_galleries/picasa_types.h b/chrome/common/media_galleries/picasa_types.h

index 6369c0af9d4249c6abf7bfa0f09b39fafd4eb990..5e54c0b4c899ac3085832ffd72a9dfa2ae82e6a7 100644

--- a/chrome/common/media_galleries/picasa_types.h

+++ b/chrome/common/media_galleries/picasa_types.h

@@ -22,13 +22,19 @@ struct AlbumInfo;

// Bar.jpg -> /path/to/Bar.jpg

// Foo.jpg -> /path/to/Foo.jpg

// Foo (1).jpg -> /path/to/another/Foo.jpg

+// TODO(tommycli): Rename this type to a more intuitive name.

typedef std::map<std::string, base::FilePath> AlbumImages;

typedef std::set<std::string> AlbumUIDSet;

// Map of album uids to a collection of its images.

typedef std::map<std::string, AlbumImages> AlbumImagesMap;

typedef std::map<std::string, AlbumInfo> AlbumMap;

-const char kPicasaAlbumTableName[] = "albumdata";

+extern const char kPicasaAlbumTableName[];

+extern const char kAlbumTokenPrefix[];

+extern const uint32 kAlbumCategoryAlbum;

+extern const uint32 kAlbumCategoryFolder;

+extern const uint32 kAlbumCategoryInvalid;

struct AlbumInfo {

AlbumInfo();