chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h - Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0039-picasa-import-sandbox-ini-parsing

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc ('K') | « chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc ('k') | chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

diff --git a/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h b/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

index 7ba576488449cf510a6d72b6220f139ee9ebf27d..676ee8f2cc84e9934b556c9198ffeb7af20b0651 100644

--- a/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

+++ b/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

@@ -31,9 +31,14 @@ namespace picasa {

// utility process replies or when it dies.

class SafePicasaAlbumTableReader : public content::UtilityProcessHostClient {

public:

- typedef base::Callback<void(bool,

+ // PicasaDataProvider keeps a reference to the last-dispatched instance of

+ // this class so it can ignore callbacks from 'stale' instances. The callback

+ // also keeps a reference so it doesn't get destroyed prematurely.

+ typedef base::Callback<void(scoped_refptr<SafePicasaAlbumTableReader>,

+ bool parse_success,

const std::vector<AlbumInfo>&,

- const std::vector<AlbumInfo>&)> ParserCallback;

+ const std::vector<AlbumInfo>&)>

+ ParserCallback;

SafePicasaAlbumTableReader(const AlbumTableFiles& album_table_files,

const ParserCallback& callback);