content/utility/utility.sb - Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/utility/utility.sb

Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0039-picasa-import-sandbox-ini-parsing

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/utility/media_galleries/picasa_album_table_reader.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 ;;	1 ;;

2 ;; Copyright (c) 2011 The Chromium Authors. All rights reserved.	2 ;; Copyright (c) 2011 The Chromium Authors. All rights reserved.

3 ;; Use of this source code is governed by a BSD-style license that can be	3 ;; Use of this source code is governed by a BSD-style license that can be

4 ;; found in the LICENSE file.	4 ;; found in the LICENSE file.

5 ;;	5 ;;

6 ; This is the Sandbox configuration file used for safeguarding the utility	6 ; This is the Sandbox configuration file used for safeguarding the utility

7 ; process which is used for performing sandboxed operations that need to touch	7 ; process which is used for performing sandboxed operations that need to touch

8 ; the filesystem like decoding theme images and unpacking extensions.	8 ; the filesystem like decoding theme images and unpacking extensions.

9 ;	9 ;

10 ; This configuration locks everything down, except access to one configurable	10 ; This configuration locks everything down, except access to one configurable

11 ; directory. This is different from other sandbox configuration files where	11 ; directory. This is different from other sandbox configuration files where

12 ; file system access is entireley restricted.	12 ; file system access is entireley restricted.

13	13

14 ; * The contents of content/common/common.sb are implicitly included here. *	14 ; * The contents of content/common/common.sb are implicitly included here. *

15	15

16 ; Enable full access to given directory if needed.	16 ; Enable full access to given directory if needed.

17 ;ENABLE_DIRECTORY_ACCESS	17 ;ENABLE_DIRECTORY_ACCESS

	18

	19 ; Enables the sandboxed utility process to get the local time. Needed to parse

	20 ; the Media Galleries API Picasa PMP database files correctly.

	21 (allow file-read-metadata

	22 (literal "/private/etc/localtime")

	23 (literal "/etc"))
	jeremy 2013/08/30 22:40:19 Per my comment in email, we generally try not to p Per my comment in email, we generally try not to punch holes in the sandbox and only do so as a last option. Can you achieve this by calling the relevant function in the sandbox warmup code? or roundtripping through the browser? tommycli 2013/08/30 22:57:04 Done. Show quoted text On 2013/08/30 22:40:19, jeremy wrote: > Per my comment in email, we generally try not to punch holes in the sandbox and > only do so as a last option. Can you achieve this by calling the relevant > function in the sandbox warmup code? or roundtripping through the browser? Done.
OLD	NEW