Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_GALLERIES_FILEAPI_SAFE_PICASA_ALBUM_TABLE_READER_H_
 #define CHROME_BROWSER_MEDIA_GALLERIES_FILEAPI_SAFE_PICASA_ALBUM_TABLE_READER_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 13 matching lines @@
 
 namespace picasa {
 
 // SafePicasaAlbumTableReader parses the given Picasa PMP Album Table safely
 // via a utility process. The SafePicasaAlbumTableReader object is ref-counted
 // and kept alive after Start() is called until the ParserCallback is called.
 // The ParserCallback is guaranteed to be called eventually either when the
 // utility process replies or when it dies.
 class SafePicasaAlbumTableReader : public content::UtilityProcessHostClient {
  public:
-  typedef base::Callback<void(bool,
+  typedef base::Callback<void(bool parse_success,
                               const std::vector<AlbumInfo>&,
-                              const std::vector<AlbumInfo>&)> ParserCallback;
+                              const std::vector<AlbumInfo>&)>
+      ParserCallback;
 
-  SafePicasaAlbumTableReader(const AlbumTableFiles& album_table_files,
-                             const ParserCallback& callback);
+  explicit SafePicasaAlbumTableReader(const AlbumTableFiles& album_table_files);
 
-  void Start();
+  void Start(const ParserCallback& callback);
 
  private:
   enum ParserState {
     INITIAL_STATE,
     PINGED_UTILITY_PROCESS_STATE,
     STARTED_PARSING_STATE,
     FINISHED_PARSING_STATE,
   };
 
   // Private because content::UtilityProcessHostClient is ref-counted.
@@ skipping 18 matching lines @@
   // Runs on the IO thread.
   virtual void OnProcessCrashed(int exit_code) OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   const AlbumTableFiles album_table_files_;
 
   // Only accessed on the IO thread.
   base::WeakPtr<content::UtilityProcessHost> utility_process_host_;
 
   // Only accessed on the Media Task Runner.
-  const ParserCallback callback_;
+  ParserCallback callback_;
 
   // Verifies the messages from the utility process came at the right time.
   // Initialized on the Media Task Runner, but only accessed on the IO thread.
   ParserState parser_state_;
 
   DISALLOW_COPY_AND_ASSIGN(SafePicasaAlbumTableReader);
 };
 
 }  // namespace picasa
 
 #endif  // CHROME_BROWSER_MEDIA_GALLERIES_FILEAPI_SAFE_PICASA_ALBUM_TABLE_READER_H_