Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 189853002: Remove --pnacl-dir override flag. (Closed)

Created:
6 years, 9 months ago by jvoung (off chromium)
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Remove --pnacl-dir override flag. It was added in case a test harness needed to point at a mock PNaCl component, but that can be done without the commandline switch. BUG=none (flags cleanup) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jvoung (off chromium)
6 years, 9 months ago (2014-03-07 16:46:50 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-07 17:28:25 UTC) #2
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 9 months ago (2014-03-07 17:34:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/189853002/1
6 years, 9 months ago (2014-03-07 17:35:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 17:36:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg, mac_chromium_rel
6 years, 9 months ago (2014-03-07 17:36:22 UTC) #6
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 9 months ago (2014-03-07 18:59:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/189853002/1
6 years, 9 months ago (2014-03-07 19:01:18 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 19:06:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg, mac_chromium_rel
6 years, 9 months ago (2014-03-07 19:06:57 UTC) #10
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 9 months ago (2014-03-07 21:49:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/189853002/1
6 years, 9 months ago (2014-03-07 21:52:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/189853002/1
6 years, 9 months ago (2014-03-08 11:02:52 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 18:02:33 UTC) #14
Message was sent while issue was closed.
Change committed as 255786

Powered by Google App Engine
This is Rietveld 408576698