Cleanup LocalDiscoveryUIHandler.

chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h"
 
 #include "base/macros.h"
 #include "base/strings/stringprintf.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/extension_apitest.h"
@@ skipping 24 matching lines @@
 
   void SetUpInProcessBrowserTestFixture() override {
     // Start up the test server and get us ready for calling the install
     // API functions.
     host_resolver()->AddRule("www.cloudprintapp.com", "127.0.0.1");
     ASSERT_TRUE(embedded_test_server()->Start());
   }
 
  protected:
   // Returns a test server URL, but with host 'www.cloudprintapp.com' so it
-   // matches the cloud print app's extent that we set up via command line
-   // flags.
+  // matches the cloud print app's extent that we set up via command line flags.
   GURL GetTestServerURL(const std::string& path) {
     GURL url = embedded_test_server()->GetURL(
         "/extensions/api_test/cloud_print_private/" + path);
 
     // Replace the host with 'www.cloudprintapp.com' so it matches the cloud
     // print app's extent.
     GURL::Replacements replace_host;
     replace_host.SetHostStr("www.cloudprintapp.com");
     return url.ReplaceComponents(replace_host);
   }
 };
 
 #if !defined(OS_CHROMEOS)
 
 using extensions::api::cloud_print_private::UserSettings;
 
 class CloudPrintTestsDelegateMock : public extensions::CloudPrintTestsDelegate {
  public:
   CloudPrintTestsDelegateMock() {}

[Vitaly Buka (NO REVIEWS), 2016/04/21 20:09:45]

why not just use the default destructor?

[Lei Zhang, 2016/04/21 20:50:22]

Did you mean with " = default;" or leave it off?

I was playing around with making the test work and at one point added other
overrides and wanted to explicitly follow the class with virtual methods should
have a virtual destruction rule.

+  ~CloudPrintTestsDelegateMock() override {}
 
   MOCK_METHOD4(SetupConnector,
                void(const std::string& user_email,
                     const std::string& robot_email,
                     const std::string& credentials,
                     const UserSettings& user_settings));
   MOCK_METHOD0(GetHostName, std::string());
   MOCK_METHOD0(GetPrinters, std::vector<std::string>());
   MOCK_METHOD0(GetClientId, std::string());
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CloudPrintTestsDelegateMock);
 };
 
 MATCHER(IsExpectedUserSettings, "") {
   const UserSettings& settings = arg;
   return settings.connect_new_printers && settings.printers.size() == 2 &&
          settings.printers[0].name == "printer1" &&
          !settings.printers[0].connect &&
          settings.printers[1].name == "printer2" &&
          settings.printers[1].connect;
 }
 
 // http://crbug.com/177163
 #if defined(OS_WIN) && !defined(NDEBUG)
-#define MAYBE_CloudPrintHosted DISABLED_CloudPrintHosted
+#define MAYBE_CloudPrintHostedWithMock DISABLED_CloudPrintHostedWithMock
 #else
-#define MAYBE_CloudPrintHosted CloudPrintHosted
+#define MAYBE_CloudPrintHostedWithMock CloudPrintHostedWithMock
 #endif
 IN_PROC_BROWSER_TEST_F(ExtensionCloudPrintPrivateApiTest,
-                       MAYBE_CloudPrintHosted) {
+                       MAYBE_CloudPrintHostedWithMock) {
   CloudPrintTestsDelegateMock cloud_print_mock;
 
   EXPECT_CALL(cloud_print_mock,
               SetupConnector("foo@gmail.com",
                              "foorobot@googleusercontent.com",
                              "1/23546efa54",
                              IsExpectedUserSettings()));
   EXPECT_CALL(cloud_print_mock, GetHostName())
       .WillRepeatedly(Return("TestHostName"));
 
   std::vector<std::string> printers;
   printers.push_back("printer1");
   printers.push_back("printer2");
   EXPECT_CALL(cloud_print_mock, GetPrinters())
       .WillRepeatedly(Return(printers));
 
   EXPECT_CALL(cloud_print_mock, GetClientId())
       .WillRepeatedly(Return("TestAPIClient"));
 
   // Run this as a hosted app. Since we have overridden the cloud print service
   // URL in the command line, this URL should match the web extent for our
   // cloud print component app and it should work.
   GURL page_url = GetTestServerURL(
       "enable_chrome_connector/cloud_print_success_tests.html");
   ASSERT_TRUE(RunPageTest(page_url.spec()));
 }
 
+IN_PROC_BROWSER_TEST_F(ExtensionCloudPrintPrivateApiTest,
+                       CloudPrintHostedIncognito) {
+  GURL page_url = GetTestServerURL(
+      "enable_chrome_connector/cloud_print_incognito_failure_tests.html");
+  ASSERT_TRUE(RunPageTest(page_url.spec(), kFlagUseIncognito));
+}
+
 #endif  // !defined(OS_CHROMEOS)