Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: appengine/findit/waterfall/try_job_util.py

Issue 1898493002: [Findit] Adding support for disabling test try jobs for given master/builder (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index 7b743498f206f95e4fecd46e67cf3952b0e70b9a..da771f551d1e1611066d2fbc6b38537b2cda8618 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -152,7 +152,8 @@ def ScheduleTryJobIfNeeded(failure_info, signals, heuristic_result):
tryserver_mastername, tryserver_buildername = (
waterfall_config.GetTrybotForWaterfallBuilder(master_name, builder_name))
- if not tryserver_mastername or not tryserver_buildername:
+ if ((not tryserver_mastername or not tryserver_buildername) or
+ not waterfall_config.EnableTestTryJobs(master_name, builder_name)):
stgao 2016/04/16 01:04:04 What if the try-job to run is for compile? also di
lijeffrey 2016/04/16 02:57:27 Done.
logging.info('%s, %s is not supported yet.', master_name, builder_name)
return {}
@@ -167,7 +168,7 @@ def ScheduleTryJobIfNeeded(failure_info, signals, heuristic_result):
if try_job_type == TryJobType.COMPILE else None)
suspected_revisions = (
_GetSuspectsForCompileFailureFromHeuristicResult(heuristic_result)
- if try_job_type == TryJobType.COMPILE else None)
+ if try_job_type == TryJobType.COMPILE else None)
pipeline = (
swarming_tasks_to_try_job_pipeline.SwarmingTasksToTryJobPipeline(

Powered by Google App Engine
This is Rietveld 408576698