Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 1898433002: Remove shell::Loader (Closed)

Created:
4 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove shell::Loader BUG=601884 R=ben@chromium.org Committed: https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b Cr-Commit-Position: refs/heads/master@{#387800} Committed: https://crrev.com/d152ac52434d55bdb39348375df3a87913837888 Cr-Commit-Position: refs/heads/master@{#387834}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : /kick gyp #

Patch Set 4 : fix windows gyp linkage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -714 lines) Patch
M services/shell/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M services/shell/background/background_shell.cc View 5 chunks +11 lines, -46 lines 0 comments Download
D services/shell/loader.h View 1 chunk +0 lines, -26 lines 0 comments Download
M services/shell/shell.h View 4 chunks +1 line, -26 lines 0 comments Download
M services/shell/shell.cc View 5 chunks +10 lines, -41 lines 0 comments Download
M services/shell/shell.gyp View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M services/shell/tests/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D services/shell/tests/loader_unittest.cc View 1 1 chunk +0 lines, -560 lines 0 comments Download
A + services/shell/tests/placeholder_unittest.cc View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Ken Rockot(use gerrit already)
4 years, 8 months ago (2016-04-15 22:47:49 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-15 22:55:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898433002/20001
4 years, 8 months ago (2016-04-15 23:01:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/197856)
4 years, 8 months ago (2016-04-15 23:33:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898433002/40001
4 years, 8 months ago (2016-04-16 01:01:14 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-16 02:44:33 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b Cr-Commit-Position: refs/heads/master@{#387800}
4 years, 8 months ago (2016-04-16 02:45:34 UTC) #12
rkc
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1899583002/ by rkc@chromium.org. ...
4 years, 8 months ago (2016-04-16 22:44:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898433002/60001
4 years, 8 months ago (2016-04-17 18:56:15 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-17 20:53:52 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-17 20:55:14 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d152ac52434d55bdb39348375df3a87913837888
Cr-Commit-Position: refs/heads/master@{#387834}

Powered by Google App Engine
This is Rietveld 408576698