Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189843009: Remove DeferredResourceLoadingTest's use of *named* shared memory. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove DeferredResourceLoadingTest's use of *named* shared memory. It's totally unnecessary (and named shared memory is now deprecated). R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255784

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M content/child/resource_dispatcher_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-07 17:16:45 UTC) #1
jam
lgtm
6 years, 9 months ago (2014-03-07 18:37:18 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-07 18:47:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/189843009/20001
6 years, 9 months ago (2014-03-07 18:49:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 18:51:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg, mac_chromium_rel
6 years, 9 months ago (2014-03-07 18:52:00 UTC) #6
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-07 19:04:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/189843009/20001
6 years, 9 months ago (2014-03-07 19:05:09 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 19:09:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 19:09:08 UTC) #10
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-07 19:22:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/189843009/20001
6 years, 9 months ago (2014-03-07 19:25:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/189843009/20001
6 years, 9 months ago (2014-03-07 20:26:53 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 20:53:32 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=82784
6 years, 9 months ago (2014-03-07 20:53:34 UTC) #15
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-07 22:53:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/189843009/20001
6 years, 9 months ago (2014-03-07 22:54:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/189843009/20001
6 years, 9 months ago (2014-03-08 11:08:19 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 13:50:00 UTC) #19
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234322
6 years, 9 months ago (2014-03-08 13:50:01 UTC) #20
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-08 16:14:33 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/189843009/20001
6 years, 9 months ago (2014-03-08 16:14:49 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 17:39:16 UTC) #23
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234465
6 years, 9 months ago (2014-03-08 17:39:17 UTC) #24
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-08 17:49:12 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/189843009/20001
6 years, 9 months ago (2014-03-08 17:49:20 UTC) #26
viettrungluu
6 years, 9 months ago (2014-03-08 18:02:06 UTC) #27
Message was sent while issue was closed. 
Committed patchset #2 manually as r255784 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698