Issue 189843006: Revert "Use Representation::Integer32() for smi types on 32-bit-tagged systems."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189843006: Revert "Use Representation::Integer32() for smi types on 32-bit-tagged systems." (Closed)

Created:
6 years, 9 months ago by Toon Verwaest

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Use Representation::Integer32() for smi types on 32-bit-tagged systems." Due to performance regression. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19709

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -20 lines)			Patch
M	src/hydrogen.cc	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/types.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/mjsunit/regress/regress-crbug-349079.js	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

6 years, 9 months ago (2014-03-07 09:29:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19709 (tree was closed).