Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: Source/core/css/CSSParserValues.h

Issue 189843005: CSSParserString::equalIgnoringCase should check string length. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed linux_debug failure. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSParserValuesTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSParserValues.h
diff --git a/Source/core/css/CSSParserValues.h b/Source/core/css/CSSParserValues.h
index 37d56aac75202f6815ea7697921650889b626eb1..854a4715514e862335bb7b736edf893be4716325 100644
--- a/Source/core/css/CSSParserValues.h
+++ b/Source/core/css/CSSParserValues.h
@@ -98,9 +98,11 @@ struct CSSParserString {
bool equalIgnoringCase(const char* str) const
{
- if (is8Bit())
- return WTF::equalIgnoringCase(str, characters8(), length());
- return WTF::equalIgnoringCase(str, characters16(), length());
+ bool match = is8Bit() ? WTF::equalIgnoringCase(str, characters8(), length()) : WTF::equalIgnoringCase(str, characters16(), length());
+ if (!match)
+ return false;
+ ASSERT(strlen(str) >= length());
+ return str[length()] == '\0';
}
template <size_t strLength>
« no previous file with comments | « no previous file | Source/core/css/CSSParserValuesTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698