Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: Source/core/css/CSSParserValues.h

Issue 189843005: CSSParserString::equalIgnoringCase should check string length. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSParserValues.h
diff --git a/Source/core/css/CSSParserValues.h b/Source/core/css/CSSParserValues.h
index 37d56aac75202f6815ea7697921650889b626eb1..1bcdb7d0d9b1de7f9b3c56d5bcef794126c92df1 100644
--- a/Source/core/css/CSSParserValues.h
+++ b/Source/core/css/CSSParserValues.h
@@ -98,9 +98,8 @@ struct CSSParserString {
bool equalIgnoringCase(const char* str) const
{
- if (is8Bit())
- return WTF::equalIgnoringCase(str, characters8(), length());
- return WTF::equalIgnoringCase(str, characters16(), length());
+ bool match = is8Bit() ? WTF::equalIgnoringCase(str, characters8(), length()) : WTF::equalIgnoringCase(str, characters16(), length());
+ return match && str[length()] == '\0';
esprehn 2014/03/07 07:05:53 Can you add an ASSERT(strlen(str) < length()) here
tasak 2014/03/07 09:55:49 Sure. I added ASSERT.
}
template <size_t strLength>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698