Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1898413004: Revert of SkOnce: 2 bytes -> 1 byte (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 8 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkOnce: 2 bytes -> 1 byte (patchset #4 id:60001 of https://codereview.chromium.org/1904483003/ ) Reason for revert: bust the roll Original issue's description: > SkOnce: 2 bytes -> 1 byte > > This uses the same logic we worked out for SkOncePtr to reduce > the memory footprint of SkOnce from a done byte and lock byte > to a single 3-state byte: > > - NotStarted: no thread has tried to run fn() yet > - Active: a thread is running fn() > - Done: fn() is complete > > Threads which see Done return immediately. > Threads which see NotStarted try to move to Active, run fn(), then move to Done. > Threads which see Active spin until the active thread moves to Done. > > This additionally fixes a too-weak memory order bug in SkOncePtr, > and adds a big note to explain. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1904483003 > > Committed: https://skia.googlesource.com/skia/+/df02d338be8e3c1c50b48a3a9faa582703a39c07 TBR=herb@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9134686fd9ce384e9163b44942538d033b5bff11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -43 lines) Patch
M include/private/SkOnce.h View 2 chunks +11 lines, -41 lines 0 comments Download
M include/private/SkOncePtr.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mtklein_C
Created Revert of SkOnce: 2 bytes -> 1 byte
4 years, 8 months ago (2016-04-20 20:02:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898413004/1
4 years, 8 months ago (2016-04-20 20:02:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9134686fd9ce384e9163b44942538d033b5bff11
4 years, 8 months ago (2016-04-20 20:02:12 UTC) #4
herb_g
4 years, 8 months ago (2016-04-20 20:36:16 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698