CacheStorage: Sync up IDL with the cache storage spec.

CacheStorage: Sync up IDL with the cache storage spec.

This CL syncs up IDL with the cache storage spec[1].
 - cache/cachestorage.match() should be Promise<any> instead of
   Promise<Response> because it can resolve undefined.
 - cache.keys() should resolve Request's sequence.

In Blink, the promise resolution types in .idl files are just annotations,
so this change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none

Committed: https://crrev.com/8ba16cb01676c42c2cb46c7fe9e3fc8a710ae7a4
Cr-Commit-Position: refs/heads/master@{#390969}

[zino, 2016-04-20 05:11:00]

Description was changed from

==========
CacheStorage: Fix a typo in Cache.idl.

According to the spec[1], cache.keys()'s promise should fulfill Request's
sequence instead of Response. This change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none
==========

to

==========
CacheStorage: Fix a typo in Cache.idl.

According to the spec[1], cache.keys()'s promise should fulfill Request's
sequence instead of Response. This change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none
==========

[zino, 2016-04-20 05:11:00]

jinho.bang@samsung.com changed reviewers:
+ nhiroki@chromium.org

[zino, 2016-04-20 05:11:17]

PTAL

Thank you.

[nhiroki, 2016-04-21 02:27:41]

Thank you for fixing this! lgtm

https://codereview.chromium.org/1898413002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/cachestorage/Cache.idl (right):

https://codereview.chromium.org/1898413002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/cachestorage/Cache.idl:10:
[CallWith=ScriptState, RaisesException] Promise<Response> match(RequestInfo
request, optional CacheQueryOptions options);
Promise<Response> -> Promise<any> ?

[nhiroki, 2016-04-25 03:29:14]

> This change doesn't affect existing behavior.

Can you mention why this change does not affect existing behavior? For example,
"The promise resolution types in .idl files are just annotations, so this change
doesn't affect existing behavior.". Developers who don't know this rule could be
a bit surprised at this change.

[zino, 2016-05-02 10:56:47]

Description was changed from

==========
CacheStorage: Fix a typo in Cache.idl.

According to the spec[1], cache.keys()'s promise should fulfill Request's
sequence instead of Response. This change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none
==========

to

==========
CacheStorage: Sync up IDL with the cache storage spec.

This CL syncs up IDL with the cache storage spec[1].
 - cache/cachestorage.match() should be Promise<any> instead of
   Promise<Response> because it can resolve undefined.
 - cache.keys() should resolve Request's sequence.

In Blink, the promise resolution types in .idl files are just annotations,
so this change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none
==========

[zino, 2016-05-02 10:57:30]

On 2016/04/25 03:29:14, nhiroki (ooo until May 9) wrote:
> > This change doesn't affect existing behavior.
> 
> Can you mention why this change does not affect existing behavior? For
example,
> "The promise resolution types in .idl files are just annotations, so this
change
> doesn't affect existing behavior.". Developers who don't know this rule could
be
> a bit surprised at this change.

Sorry for delayed response.

I updated this CL as per your comment.

Could you review again?

Thank you!

[nhiroki, 2016-05-02 12:56:12]

lgtm!

[zino, 2016-05-02 13:22:58]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2016-05-02 13:23:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898413002/20001

[commit-bot: I haz the power, 2016-05-02 17:06:33]

Description was changed from

==========
CacheStorage: Sync up IDL with the cache storage spec.

This CL syncs up IDL with the cache storage spec[1].
 - cache/cachestorage.match() should be Promise<any> instead of
   Promise<Response> because it can resolve undefined.
 - cache.keys() should resolve Request's sequence.

In Blink, the promise resolution types in .idl files are just annotations,
so this change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none
==========

to

==========
CacheStorage: Sync up IDL with the cache storage spec.

This CL syncs up IDL with the cache storage spec[1].
 - cache/cachestorage.match() should be Promise<any> instead of
   Promise<Response> because it can resolve undefined.
 - cache.keys() should resolve Request's sequence.

In Blink, the promise resolution types in .idl files are just annotations,
so this change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none
==========

[commit-bot: I haz the power, 2016-05-02 17:06:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-02 17:07:37]

Description was changed from

==========
CacheStorage: Sync up IDL with the cache storage spec.

This CL syncs up IDL with the cache storage spec[1].
 - cache/cachestorage.match() should be Promise<any> instead of
   Promise<Response> because it can resolve undefined.
 - cache.keys() should resolve Request's sequence.

In Blink, the promise resolution types in .idl files are just annotations,
so this change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none
==========

to

==========
CacheStorage: Sync up IDL with the cache storage spec.

This CL syncs up IDL with the cache storage spec[1].
 - cache/cachestorage.match() should be Promise<any> instead of
   Promise<Response> because it can resolve undefined.
 - cache.keys() should resolve Request's sequence.

In Blink, the promise resolution types in .idl files are just annotations,
so this change doesn't affect existing behavior.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG=none

Committed: https://crrev.com/8ba16cb01676c42c2cb46c7fe9e3fc8a710ae7a4
Cr-Commit-Position: refs/heads/master@{#390969}
==========

[commit-bot: I haz the power, 2016-05-02 17:07:38]

Patchset 2 (id:??) landed as
https://crrev.com/8ba16cb01676c42c2cb46c7fe9e3fc8a710ae7a4
Cr-Commit-Position: refs/heads/master@{#390969}