third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp - Issue 1898403002: [WIP] Implement :dir()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 1898403002: [WIP] Implement :dir() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase... other changes too probably Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

index b589dc52d771fec8f3f2d1de028c5bf3d666afd5..fee0d4eb8b14b2a62c494ae024abdd215db5ca67 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

@@ -779,8 +779,7 @@ String HTMLTextFormControlElement::directionForFormData() const

return dirAttributeValue;

if (equalIgnoringCase(dirAttributeValue, "auto")) {

- bool isAuto;

- TextDirection textDirection = element->directionalityIfhasDirAutoAttribute(isAuto);

+ TextDirection textDirection = element->directionality();

return textDirection == RTL ? "rtl" : "ltr";

}