Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.h

Issue 1898403002: [WIP] Implement :dir() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase... other changes too probably Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLElement.h b/third_party/WebKit/Source/core/html/HTMLElement.h
index de36fa875214e85d446f253999ce37b59a8113f5..37078cd883f6fbd602f2c92f0f136d311f364a59 100644
--- a/third_party/WebKit/Source/core/html/HTMLElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLElement.h
@@ -80,7 +80,7 @@ public:
HTMLFormElement* findFormAncestor() const;
bool hasDirectionAuto() const;
- TextDirection directionalityIfhasDirAutoAttribute(bool& isAuto) const;
+ void cacheDirectionalityForDirAuto() const;
virtual bool isHTMLUnknownElement() const { return false; }
virtual bool isPluginElement() const { return false; }
@@ -118,7 +118,7 @@ protected:
unsigned parseBorderWidthAttribute(const AtomicString&) const;
void childrenChanged(const ChildrenChange&) override;
- void calculateAndAdjustDirectionality();
+ void updateForDirAuto();
private:
String debugNodeName() const final;
@@ -133,9 +133,9 @@ private:
bool selfOrAncestorHasDirAutoAttribute() const;
void dirAttributeChanged(const AtomicString&);
- void adjustDirectionalityIfNeededAfterChildAttributeChanged(Element* child);
+ void updateSelfOrAncestorForDirAuto();
void adjustDirectionalityIfNeededAfterChildrenChanged(const ChildrenChange&);
- TextDirection directionality(Node** strongDirectionalityTextNode= 0) const;
+ TextDirection computeDirectionality(Node** strongDirectionalityTextNode = 0) const;
TranslateAttributeMode translateAttributeMode() const;

Powered by Google App Engine
This is Rietveld 408576698