third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp - Issue 1898403002: [WIP] Implement :dir()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

Issue 1898403002: [WIP] Implement :dir() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase... other changes too probably Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

index 02c00b69cde15270781ff7e781adce9a48192fb1..ce011af40c653340d96f9ca142b2af5a59dfd503 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

@@ -525,9 +525,10 @@ PassOwnPtr<CSSParserSelector> CSSSelectorParser::consumePseudo(CSSParserTokenRan

selector->adoptSelectorVector(selectorVector);

return selector.release();

}

+ case CSSSelector::PseudoDir:

case CSSSelector::PseudoLang:

{

- // FIXME: CSS Selectors Level 4 allows :lang(*-foo)

+ // FIXME: CSS Selectors Level 4 allows :lang("foo")

const CSSParserToken& ident = block.consumeIncludingWhitespace();

if (ident.type() != IdentToken || !block.atEnd())

return nullptr;