Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Issue 1898383004: Makes views_mus_unittests depend upon ui_test_pak (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes views_mus_unittests depend upon ui_test_pak As it's needed to run the tests. R=jamescook@chromium.org BUG=605232 Committed: https://crrev.com/fd7327ae9bfb6aa4c4dc7b43cf58701648542a26 Cr-Commit-Position: refs/heads/master@{#388789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sky
4 years, 8 months ago (2016-04-20 20:44:31 UTC) #1
James Cook
lgtm
4 years, 8 months ago (2016-04-20 20:46:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898383004/1
4 years, 8 months ago (2016-04-20 20:48:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/215785)
4 years, 8 months ago (2016-04-20 21:52:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898383004/1
4 years, 8 months ago (2016-04-21 16:07:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 16:45:14 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:35:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd7327ae9bfb6aa4c4dc7b43cf58701648542a26
Cr-Commit-Position: refs/heads/master@{#388789}

Powered by Google App Engine
This is Rietveld 408576698