Worker: Strictly check the current running thread

Worker: Strictly check the current running thread

BUG=n/a

Committed: https://crrev.com/15530c60150b1015a58b27153acea9af60dd3937
Cr-Commit-Position: refs/heads/master@{#389745}

[nhiroki, 2016-04-22 10:07:24]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-04-22 10:07:33]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2016-04-22 10:16:28]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2016-04-22 10:16:41]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2016-04-22 10:16:47]

Patchset #1 (id:80001) has been deleted

[nhiroki, 2016-04-22 10:16:53]

Patchset #1 (id:100001) has been deleted

[nhiroki, 2016-04-22 10:42:32]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org, yhirano@chromium.org

[nhiroki, 2016-04-22 10:42:32]

PTAL, thanks!

[kinuko, 2016-04-25 06:51:28]

generally looking good

https://codereview.chromium.org/1898363003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
(right):

https://codereview.chromium.org/1898363003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h:101: bool
isWorkerObjectThread() const;
It's true that we use the term 'worker object thread' in some of the comments (I
think they're from webkit era) but I generally find it pretty confusing... is
that only me? could we come up with a better name?  isParentContextThread() or
something like that?

https://codereview.chromium.org/1898363003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/1898363003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp:59: #include
"public/platform/Platform.h"
is this change needed by this patch?

[nhiroki, 2016-04-26 07:01:03]

Thank you for reviewing! Updated.

https://codereview.chromium.org/1898363003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
(right):

https://codereview.chromium.org/1898363003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h:101: bool
isWorkerObjectThread() const;
On 2016/04/25 06:51:27, kinuko wrote:
> It's true that we use the term 'worker object thread' in some of the comments
(I
> think they're from webkit era) but I generally find it pretty confusing... is
> that only me? could we come up with a better name?  isParentContextThread() or
> something like that?

ParentContextThread sounds better. Replaced them.

https://codereview.chromium.org/1898363003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/1898363003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp:59: #include
"public/platform/Platform.h"
On 2016/04/25 06:51:27, kinuko wrote:
> is this change needed by this patch?

Yes, this is necessary. WebSharedWorkerImpl indirectly included Platform.h and
removing unnecessary header files from other files fails to compile this.

[yhirano, 2016-04-26 07:44:46]

lgtm

https://codereview.chromium.org/1898363003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
(right):

https://codereview.chromium.org/1898363003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp:47:
#include "core/workers/WorkerThreadStartupData.h"
#include "wtf/WTF.h"

[kinuko, 2016-04-26 08:07:07]

lgtm.

[nhiroki, 2016-04-26 08:09:02]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-04-26 08:09:03]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1898363003/#ps200001
(title: "include WTF.h")

[commit-bot: I haz the power, 2016-04-26 08:09:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898363003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898363003/200001

[commit-bot: I haz the power, 2016-04-26 08:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 08:20:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nhiroki, 2016-04-26 09:00:45]

Description was changed from

==========
Worker: Strictly check the current running thread

BUG=
==========

to

==========
Worker: Strictly check the current running thread

BUG=n/a
==========

[nhiroki, 2016-04-26 09:01:32]

Description was changed from

==========
Worker: Strictly check the current running thread

BUG=n/a
==========

to

==========
Worker: Strictly check the current running thread

BUG=n/a
TBR=haraken@chromium.org
==========

[nhiroki, 2016-04-26 09:01:32]

nhiroki@chromium.org changed reviewers:
+ haraken@chromium.org

[nhiroki, 2016-04-26 09:07:44]

+haraken@ for Source/web/WebSharedWorkerImpl.cpp

Let me use TBR because this simply adds one header inclusion and the header file
has already been included implicitly before this CL.

[haraken, 2016-04-26 09:08:12]

LGTM

[nhiroki, 2016-04-26 09:09:40]

Patchset #6 (id:220001) has been deleted

[nhiroki, 2016-04-26 09:10:14]

On 2016/04/26 09:08:12, haraken wrote:
> LGTM

Ah, thank you! :)

[nhiroki, 2016-04-26 09:10:24]

Description was changed from

==========
Worker: Strictly check the current running thread

BUG=n/a
TBR=haraken@chromium.org
==========

to

==========
Worker: Strictly check the current running thread

BUG=n/a
==========

[nhiroki, 2016-04-26 09:42:14]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-04-26 09:42:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
yhirano@chromium.org, kinuko@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1898363003/#ps240001
(title: " ")

[commit-bot: I haz the power, 2016-04-26 09:42:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898363003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898363003/240001

[commit-bot: I haz the power, 2016-04-26 11:08:00]

Description was changed from

==========
Worker: Strictly check the current running thread

BUG=n/a
==========

to

==========
Worker: Strictly check the current running thread

BUG=n/a
==========

[commit-bot: I haz the power, 2016-04-26 11:08:01]

Committed patchset #6 (id:240001)

[commit-bot: I haz the power, 2016-04-26 11:09:22]

Description was changed from

==========
Worker: Strictly check the current running thread

BUG=n/a
==========

to

==========
Worker: Strictly check the current running thread

BUG=n/a

Committed: https://crrev.com/15530c60150b1015a58b27153acea9af60dd3937
Cr-Commit-Position: refs/heads/master@{#389745}
==========

[commit-bot: I haz the power, 2016-04-26 11:09:23]

Patchset 6 (id:??) landed as
https://crrev.com/15530c60150b1015a58b27153acea9af60dd3937
Cr-Commit-Position: refs/heads/master@{#389745}