Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1898363002: Reland of Fix a bug that mime type isn't passed when checking Codec capabilities (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix a bug that mime type isn't passed when checking Codec capabilities (patchset #1 id:1 of https://codereview.chromium.org/1898353002/ ) Reason for revert: reverting https://codereview.chromium.org/1900843003/ will cause youtube to fail on JDQ devices. And a fix to crbug/604917 has already been committed as a result of: https://codereview.chromium.org/1899303002/ So Revert the revert CL. Original issue's description: > Revert of Fix a bug that mime type isn't passed when checking Codec capabilities (patchset #1 id:1 of https://codereview.chromium.org/1900843003/ ) > > Reason for revert: > CL cause of crbug/604917 > Locally reverted this CL to confirm > > Original issue's description: > > Fix a bug that mime type isn't passed when checking Codec capabilities > > > > Chrome is passing wrong MIME type when checking vp8/9 codec capability. > > We should use video/x-vnd.on2.vp8, but using vp8 instead. > > This is a simple fix so that it can be easily merged. > > An improvement of the CL can be found at https://codereview.chromium.org/1897003002 > > > > TBR=timav@chromium.org > > BUG=603162 > > > > Committed: https://crrev.com/a4631e6a7033e606cd29d662dbb040e8e1ceb4fe > > Cr-Commit-Position: refs/heads/master@{#388066} > > TBR=timav@chromium.org,ddorwin@chromium.org,qinmin@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=603162 TBR=timav@chromium.org,ddorwin@chromium.org,mikecase@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603162 Committed: https://crrev.com/fd9b780dacc3c51543d40ed4e74fd7a000666025 Cr-Commit-Position: refs/heads/master@{#388351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M media/base/android/media_codec_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
qinmin
Created Reland of Fix a bug that mime type isn't passed when checking Codec capabilities
4 years, 8 months ago (2016-04-19 23:23:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898363002/1
4 years, 8 months ago (2016-04-19 23:23:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 23:24:37 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:17:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd9b780dacc3c51543d40ed4e74fd7a000666025
Cr-Commit-Position: refs/heads/master@{#388351}

Powered by Google App Engine
This is Rietveld 408576698