Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1898353004: Revert of Re-Reland Combined test runner. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Re-Reland Combined test runner. (patchset #4 id:80001 of https://codereview.chromium.org/1888673003/ ) Reason for revert: Dr.Memory code is wrong..... Original issue's description: > Re-Reland Combined test runner. > > Original Commit Message: > > This CL revives the old CL to combine the test runners [1] which was reverted > due to failing font_size tests. I've deleted the font_size.pdf as it is not > needed and for testing. Pixel tests are either .in or .pdf files, not both. > > Original description: > This CL takes the three test runners (corpus, javascript, pixel) and combines > the code into a single test_runner file. Each of the individual runners still > exists and calls the test runner with their data directory. > > With this change, the pixel and javascript test will now run in parallel if > multiple processors are available. > > 1-https://codereview.chromium.org/1430623006/ > > BUG= > > Committed: https://pdfium.googlesource.com/pdfium/+/84b26ec6ba8193235ce0df817dec5c0f1da29841 TBR=ochang@chromium.org,zhaoqin@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://pdfium.googlesource.com/pdfium/+/fb0e3d754db6980d1c8224f7b38070c12ac9eaea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -259 lines) Patch
A testing/resources/pixel/font_size.pdf View 1 chunk +72 lines, -0 lines 0 comments Download
M testing/tools/common.py View 2 chunks +0 lines, -8 lines 0 comments Download
M testing/tools/run_corpus_tests.py View 1 chunk +166 lines, -3 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 chunk +90 lines, -3 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 chunk +99 lines, -3 lines 0 comments Download
D testing/tools/test_runner.py View 1 chunk +0 lines, -242 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
Created Revert of Re-Reland Combined test runner.
4 years, 8 months ago (2016-04-20 14:05:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898353004/1
4 years, 8 months ago (2016-04-20 14:05:23 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 14:05:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/fb0e3d754db6980d1c8224f7b38070c12ac9...

Powered by Google App Engine
This is Rietveld 408576698