Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1898353003: [Android] Fix device handling in adb_reverse_forwarder.py. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, nyquist
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix device handling in adb_reverse_forwarder.py. BUG= Committed: https://crrev.com/884cfea7f0534a79daff21c7493f14647c56c6f1 Cr-Commit-Position: refs/heads/master@{#388419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/adb_reverse_forwarder.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jbudorick
4 years, 8 months ago (2016-04-20 01:19:16 UTC) #2
agrieve
On 2016/04/20 01:19:16, jbudorick wrote: lgtm
4 years, 8 months ago (2016-04-20 01:36:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898353003/1
4 years, 8 months ago (2016-04-20 01:38:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/214071)
4 years, 8 months ago (2016-04-20 02:39:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898353003/1
4 years, 8 months ago (2016-04-20 02:48:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 03:28:10 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:20:38 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/884cfea7f0534a79daff21c7493f14647c56c6f1
Cr-Commit-Position: refs/heads/master@{#388419}

Powered by Google App Engine
This is Rietveld 408576698