Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1898273002: 🐢 Make create_native_executable_dist() mark its dir as data (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make create_native_executable_dist() mark its dir as data Should fix breakpad_unittests on GN swarming bot. BUG=589318 Committed: https://crrev.com/ea3e8c1bada12e5ec3a168561076a94f2513d895 Cr-Commit-Position: refs/heads/master@{#388301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
agrieve
On 2016/04/19 18:08:43, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org
4 years, 8 months ago (2016-04-19 18:08:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898273002/1
4 years, 8 months ago (2016-04-19 18:09:41 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 18:56:28 UTC) #7
Yaron
lgtm
4 years, 8 months ago (2016-04-19 20:29:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898273002/1
4 years, 8 months ago (2016-04-19 20:39:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 20:43:24 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea3e8c1bada12e5ec3a168561076a94f2513d895
Cr-Commit-Position: refs/heads/master@{#388301}

Powered by Google App Engine
This is Rietveld 408576698