Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.h

Issue 1898233002: Report expected task queueing time via UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Super rough alternative approach. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/renderer_scheduler_impl.h
diff --git a/components/scheduler/renderer/renderer_scheduler_impl.h b/components/scheduler/renderer/renderer_scheduler_impl.h
index 2ec8887409e32dc0cde3f10e0c1f86a65b0a13b4..068385a7c5fc92701a26eb28f6ba5bacc50fa6b2 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl.h
+++ b/components/scheduler/renderer/renderer_scheduler_impl.h
@@ -11,8 +11,10 @@
#include "components/scheduler/base/pollable_thread_safe_flag.h"
#include "components/scheduler/child/idle_helper.h"
#include "components/scheduler/child/scheduler_helper.h"
+#include "components/scheduler/renderer/coarse_duration_timer.h"
#include "components/scheduler/renderer/deadline_task_runner.h"
#include "components/scheduler/renderer/idle_time_estimator.h"
+#include "components/scheduler/renderer/queueing_time_estimator.h"
#include "components/scheduler/renderer/render_widget_signals.h"
#include "components/scheduler/renderer/renderer_scheduler.h"
#include "components/scheduler/renderer/task_cost_estimator.h"
@@ -36,7 +38,8 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
: public RendererScheduler,
public IdleHelper::Delegate,
public SchedulerHelper::Observer,
- public RenderWidgetSignals::Observer {
+ public RenderWidgetSignals::Observer,
+ public QueueingTimeEstimator::Client {
public:
RendererSchedulerImpl(scoped_refptr<SchedulerTqmDelegate> main_task_runner);
~RendererSchedulerImpl() override;
@@ -92,6 +95,9 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
void OnTriedToExecuteBlockedTask(const TaskQueue& queue,
const base::PendingTask& task) override;
+ // QueueingTimeEstimator::QueueingTimeEstimatorClient implementation:
+ void OnQueueingTimeForWindowEstimated(base::TimeDelta queueing_time) override;
+
// Returns a task runner where tasks run at the highest possible priority.
scoped_refptr<TaskQueue> ControlTaskRunner();
@@ -316,13 +322,15 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
// (the accessors) for the following data members.
struct MainThreadOnly {
- MainThreadOnly(const scoped_refptr<TaskQueue>& compositor_task_runner,
+ MainThreadOnly(RendererSchedulerImpl* renderer_scheduler_impl,
+ const scoped_refptr<TaskQueue>& compositor_task_runner,
base::TickClock* time_source);
~MainThreadOnly();
TaskCostEstimator loading_task_cost_estimator;
TaskCostEstimator timer_task_cost_estimator;
IdleTimeEstimator idle_time_estimator;
+ QueueingTimeEstimator queueing_time_estimator;
UseCase current_use_case;
Policy current_policy;
base::TimeTicks current_policy_expiration_time;
@@ -414,6 +422,12 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
return compositor_thread_only_;
}
+ CoarseDurationTimer* coarse_duration_timer() {
+ return &coarse_duration_timer_;
+ }
+
+ CoarseDurationTimer coarse_duration_timer_;
+ bool coarse_duration_timer_observing_;
PollableThreadSafeFlag policy_may_need_update_;
base::WeakPtrFactory<RendererSchedulerImpl> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698