Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: components/scheduler/renderer/idle_time_estimator_unittest.cc

Issue 1898233002: Report expected task queueing time via UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/idle_time_estimator_unittest.cc
diff --git a/components/scheduler/renderer/idle_time_estimator_unittest.cc b/components/scheduler/renderer/idle_time_estimator_unittest.cc
index c50ad837240d292150338c37b4ee57b59b9cde30..986a36127402ba19112b88fdee182d4c115fe925 100644
--- a/components/scheduler/renderer/idle_time_estimator_unittest.cc
+++ b/components/scheduler/renderer/idle_time_estimator_unittest.cc
@@ -8,6 +8,7 @@
#include "base/test/simple_test_tick_clock.h"
#include "cc/test/ordered_simple_task_runner.h"
#include "components/scheduler/base/task_queue_manager.h"
+#include "components/scheduler/base/test_task_time_tracker.h"
#include "components/scheduler/base/test_time_source.h"
#include "components/scheduler/child/scheduler_tqm_delegate_for_test.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -43,9 +44,9 @@ class IdleTimeEstimatorTest : public testing::Test {
new cc::OrderedSimpleTaskRunner(clock_.get(), false));
main_task_runner_ = SchedulerTqmDelegateForTest::Create(
mock_task_runner_, base::WrapUnique(new TestTimeSource(clock_.get())));
- manager_ = base::WrapUnique(
- new TaskQueueManager(main_task_runner_, "test.scheduler",
- "test.scheduler", "test.scheduler.debug"));
+ manager_ = base::WrapUnique(new TaskQueueManager(
sdefresne 2016/07/06 14:51:32 nit: would be better to use base::MakeUnique inste
tdresser 2016/07/06 15:09:21 Done.
+ main_task_runner_, "test.scheduler", "test.scheduler",
+ "test.scheduler.debug"));
compositor_task_runner_ =
manager_->NewTaskQueue(TaskQueue::Spec("compositor_tq"));
estimator_.reset(new IdleTimeEstimatorForTest(
@@ -92,6 +93,7 @@ class IdleTimeEstimatorTest : public testing::Test {
scoped_refptr<TaskQueue> compositor_task_runner_;
std::unique_ptr<IdleTimeEstimatorForTest> estimator_;
const base::TimeDelta frame_length_;
+ TestTaskTimeTracker test_task_time_tracker_;
};
TEST_F(IdleTimeEstimatorTest, InitialTimeEstimateWithNoData) {

Powered by Google App Engine
This is Rietveld 408576698