Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1898193006:
Remove isolate_file variable from breakpad unittest gyp. (Closed)
|
Created:
4 years, 8 months ago by mikecase (-- gone --) Modified:
4 years, 8 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove isolate_file variable from breakpad unittest gyp.
This isolate file doesn't appear to exist anyone. Breakpad
unittests are failing due to not being able to find this file.
TBR=thestig@chromium.org
BUG=
Committed: https://crrev.com/fe8e72181a719e79851cd28a25986b098bd862e3
Cr-Commit-Position: refs/heads/master@{#388330}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
mikecase@chromium.org changed reviewers: + jbudorick@chromium.org
jbudorick@chromium.org changed reviewers: + agrieve@chromium.org
lgtm +agrieve fyi
The CQ bit was checked by mikecase@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898193006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898193006/1
mikecase@chromium.org changed reviewers: + thestig@chromium.org
+ thestig@chromium.org for owner of breakpad/
Description was changed from ========== Remove isolate_file variable from breakpad unittest gyp. This isolate file doesn't appear to exist anyone. Breakpad unittests are failing due to not being able to find this file. BUG= ========== to ========== Remove isolate_file variable from breakpad unittest gyp. This isolate file doesn't appear to exist anyone. Breakpad unittests are failing due to not being able to find this file. TBR=thestig@chromium.org BUG= ==========
lgtm
FTR, r385084 removed the GN reference to the .isolate file, but didn't touch GYP.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mikecase@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898193006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898193006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove isolate_file variable from breakpad unittest gyp. This isolate file doesn't appear to exist anyone. Breakpad unittests are failing due to not being able to find this file. TBR=thestig@chromium.org BUG= ========== to ========== Remove isolate_file variable from breakpad unittest gyp. This isolate file doesn't appear to exist anyone. Breakpad unittests are failing due to not being able to find this file. TBR=thestig@chromium.org BUG= Committed: https://crrev.com/fe8e72181a719e79851cd28a25986b098bd862e3 Cr-Commit-Position: refs/heads/master@{#388330} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fe8e72181a719e79851cd28a25986b098bd862e3 Cr-Commit-Position: refs/heads/master@{#388330} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
