Issue 1898193004: TBR Revert "Remove MemberMap in favor of HashMap"

Issue 1898193004: TBR Revert "Remove MemberMap in favor of HashMap" (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson

Modified:
4 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+417 lines, -201 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	2 chunks	+11 lines, -9 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	25 chunks	+241 lines, -74 lines	0 comments	Download
M	pkg/analyzer/test/generated/inheritance_manager_test.dart	View	30 chunks	+112 lines, -112 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	2 chunks	+47 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Brian Wilkerson

Unfortunately, InheritanceManager is used by client code, so this was a breaking change.

4 years, 8 months ago (2016-04-19 19:20:37 UTC) #2

Brian Wilkerson

Committed patchset #1 (id:1) manually as 9aa64259dc09175978c853235e542d32e60bb5b5 (presubmit successful).

4 years, 8 months ago (2016-04-19 19:20:53 UTC) #4

Brian Wilkerson

4 years, 8 months ago (2016-04-19 19:25:57 UTC) #6

Message was sent while issue was closed.

I'll have a non-breaking version of the changes out soon.