vm: x64 disassembler fix

vm: x64 disassembler fix

1. Fixes printing of testb rdx,0x0x1

2. Print immediates in the range 0-9 as decimal.

3. Simplify printing of displacements.

R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/e072ae33c6c58d925cd0ec48f0992d8c4d14affb

[sra1, 2016-04-19 19:35:47]

sra@google.com changed reviewers:
+ regis@google.com

[sra1, 2016-04-19 19:35:48]

I started out fixing

   testb rcx,0x0x1

which is clearly wrong. Since think

   testb rcx,1

is more readable than

   testb rcx,0x1

i changed all immediate values to be single digit if they are the 'same' in hex
or decimal.

[regis, 2016-04-19 20:59:22]

LGTM

Since all the helpers start with "Print", I would take this opportunity to
rename AppendToBuffer to Print.

https://codereview.chromium.org/1898173005/diff/1/runtime/vm/disassembler_x64.cc
File runtime/vm/disassembler_x64.cc (right):

https://codereview.chromium.org/1898173005/diff/1/runtime/vm/disassembler_x64...
runtime/vm/disassembler_x64.cc:563: if (value >= 0 && value <= 9) {
((value >= 0) && (value <= 9))

[sra1, 2016-04-19 22:04:38]

Description was changed from

==========
vm: x64 disassembler fix

1. Fixes printing of testb rdx,0x0x1

2. Print immediates in the range 0-9 as decimal.

3. Simplify printing of displacements.
==========

to

==========
vm: x64 disassembler fix

1. Fixes printing of testb rdx,0x0x1

2. Print immediates in the range 0-9 as decimal.

3. Simplify printing of displacements.

R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e072ae33c6c58d925cd0ec48f0992d8c4d14affb
==========

[sra1, 2016-04-19 22:04:39]

Committed patchset #3 (id:40001) manually as
e072ae33c6c58d925cd0ec48f0992d8c4d14affb (presubmit successful).

[sra1, 2016-04-19 23:32:39]

https://codereview.chromium.org/1898173005/diff/1/runtime/vm/disassembler_x64.cc
File runtime/vm/disassembler_x64.cc (right):

https://codereview.chromium.org/1898173005/diff/1/runtime/vm/disassembler_x64...
runtime/vm/disassembler_x64.cc:563: if (value >= 0 && value <= 9) {
On 2016/04/19 20:59:22, regis wrote:
> ((value >= 0) && (value <= 9))

Done.