Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1898173002: Remove IPDF_CryptoHandler and IPDF_SecurityHandler. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IPDF_CryptoHandler and IPDF_SecurityHandler. This CL replaces the interfaces with the concrete classes. The concrete classes are also renamed to remove the Standard from their names. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/2fa0e13ec2a79cc85d5e018a6420e677b28160cc

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -1502 lines) Patch
M BUILD.gn View 3 chunks +4 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 9 chunks +11 lines, -11 lines 3 comments Download
M core/fpdfapi/fpdf_edit/include/cpdf_creator.h View 3 chunks +3 lines, -3 lines 0 comments Download
A core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h View 1 chunk +67 lines, -0 lines 0 comments Download
A + core/fpdfapi/fpdf_parser/cpdf_crypto_handler.cpp View 7 chunks +54 lines, -59 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
A + core/fpdfapi/fpdf_parser/cpdf_security_handler.h View 2 chunks +21 lines, -17 lines 0 comments Download
A + core/fpdfapi/fpdf_parser/cpdf_security_handler.cpp View 16 chunks +69 lines, -77 lines 0 comments Download
D core/fpdfapi/fpdf_parser/cpdf_standard_crypto_handler.h View 1 chunk +0 lines, -64 lines 0 comments Download
D core/fpdfapi/fpdf_parser/cpdf_standard_crypto_handler.cpp View 1 chunk +0 lines, -342 lines 0 comments Download
D core/fpdfapi/fpdf_parser/cpdf_standard_security_handler.h View 1 chunk +0 lines, -105 lines 0 comments Download
D core/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp View 1 chunk +0 lines, -715 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_parser.h View 3 chunks +4 lines, -4 lines 0 comments Download
D core/fpdfapi/fpdf_parser/ipdf_crypto_handler.h View 1 chunk +0 lines, -45 lines 0 comments Download
D core/fpdfapi/fpdf_parser/ipdf_security_handler.h View 1 chunk +0 lines, -36 lines 0 comments Download
M pdfium.gyp View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-19 15:01:03 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-19 17:31:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898173002/1
4 years, 8 months ago (2016-04-19 17:32:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/2fa0e13ec2a79cc85d5e018a6420e677b28160cc
4 years, 8 months ago (2016-04-19 17:32:50 UTC) #7
Tom Sepez
lgtm https://codereview.chromium.org/1898173002/diff/1/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right): https://codereview.chromium.org/1898173002/diff/1/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp#newcode494 core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:494: FX_BOOL CPDF_Encryptor::Initialize(CPDF_CryptoHandler* pHandler, Always returns true, should be ...
4 years, 8 months ago (2016-04-19 17:35:43 UTC) #8
dsinclair
4 years, 8 months ago (2016-04-19 17:38:43 UTC) #9
Message was sent while issue was closed. 
On 2016/04/19 17:35:43, Tom Sepez wrote:
> lgtm
> 
>
https://codereview.chromium.org/1898173002/diff/1/core/fpdfapi/fpdf_edit/fpdf...
> File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):
> 
>
https://codereview.chromium.org/1898173002/diff/1/core/fpdfapi/fpdf_edit/fpdf...
> core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:494: FX_BOOL
> CPDF_Encryptor::Initialize(CPDF_CryptoHandler* pHandler,
> Always returns true, should be void, or do work in ctor instead.
> 
>
https://codereview.chromium.org/1898173002/diff/1/core/fpdfapi/fpdf_edit/fpdf...
> core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:1070: CPDF_CryptoHandler* pHandler
=
> nullptr;
> nit: combine with next line.
> 
>
https://codereview.chromium.org/1898173002/diff/1/core/fpdfapi/fpdf_edit/fpdf...
> core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:2016: if (m_bNewCrypto) {
> This pattern is better served by an unique ptr.


Will post a followup, these came in after it committed .....

Powered by Google App Engine
This is Rietveld 408576698