Issue 1898163002: Generate cached_patches.dart using new Dartium swtich

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1898163002: Generate cached_patches.dart using new Dartium swtich (Closed)

Created:
4 years, 8 months ago by terry

Modified:
4 years, 8 months ago

Reviewers:
Alan Knight, Jacob

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

The patch file cached_patches.dart generated from C++ with special dartium switch --enable-blink-features=dartGenCachedPatches TBR=jacobr@google.com,alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/e8fd9f5c1f9f3e5df1265cf762ceac5170c40621

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -67 lines)			Patch
M	sdk/lib/js/dartium/cached_patches.dart	View	7 chunks	+15 lines, -7 lines	0 comments	Download
M	sdk/lib/js/dartium/js_dartium.dart	View	4 chunks	+11 lines, -46 lines	0 comments	Download
M	tools/dartium/generate_app/generate_cached_patches.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	tools/dartium/generate_app/generate_cached_patches.html	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/dartium/generate_patches.sh	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	tools/deps/dartium.deps/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

terry

The patch file cached_patches.dart is nowgenerated from C++ using the special dartium switch --enable-blink-features=dartGenCachedPatches

4 years, 8 months ago (2016-04-19 15:31:17 UTC) #1

terry

Committed patchset #1 (id:1) manually as e8fd9f5c1f9f3e5df1265cf762ceac5170c40621 (presubmit successful).

4 years, 8 months ago (2016-04-19 15:33:03 UTC) #3

Message was sent while issue was closed.

lgtm